- Revision
- 260947
- Author
- [email protected]
- Date
- 2020-04-30 06:38:40 -0700 (Thu, 30 Apr 2020)
Log Message
[SOUP] http/tests/media/video-accept-encoding.html fails
https://bugs.webkit.org/show_bug.cgi?id=211228
Reviewed by Carlos Garcia Campos.
Source/WebCore:
The resource requests received by the network process always had
the accept-encoding setting enabled due to lack of IPC
(de)serialization for this boolean.
The patch also enables soup release logging, set WEBKIT_DEBUG=Network=debug.
* platform/network/soup/ResourceRequest.h:
(WebCore::ResourceRequest::encodeWithPlatformData const):
(WebCore::ResourceRequest::decodeWithPlatformData):
* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::soupLogPrinter):
(WebCore::SoupNetworkSession::setupLogger):
Tools:
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):
LayoutTests:
* platform/gtk/TestExpectations: Unflag passing tests.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (260946 => 260947)
--- trunk/LayoutTests/ChangeLog 2020-04-30 12:58:53 UTC (rev 260946)
+++ trunk/LayoutTests/ChangeLog 2020-04-30 13:38:40 UTC (rev 260947)
@@ -1,5 +1,14 @@
2020-04-30 Philippe Normand <[email protected]>
+ [SOUP] http/tests/media/video-accept-encoding.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=211228
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/gtk/TestExpectations: Unflag passing tests.
+
+2020-04-30 Philippe Normand <[email protected]>
+
REGRESSION(r260822): Apparently broke media/track/track-cue-missing.html on Mac
https://bugs.webkit.org/show_bug.cgi?id=211194
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (260946 => 260947)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2020-04-30 12:58:53 UTC (rev 260946)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-04-30 13:38:40 UTC (rev 260947)
@@ -3569,10 +3569,6 @@
Bug(GTK) fast/css/sticky/sticky-top-zoomed.html [ ImageOnlyFailure ]
-# Shared workers disabled with the Network Process
-webkit.org/b/139357 fast/workers/worker-crash-with-invalid-location.html [ Skip ]
-webkit.org/b/139357 http/tests/media/video-accept-encoding.html [ Failure ]
-
# There is no network load scheduling or prioritization with NetworkProcess.
webkit.org/b/123431 http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html [ Failure Pass ]
webkit.org/b/123431 http/tests/local/link-stylesheet-load-order-preload.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (260946 => 260947)
--- trunk/Source/WebCore/ChangeLog 2020-04-30 12:58:53 UTC (rev 260946)
+++ trunk/Source/WebCore/ChangeLog 2020-04-30 13:38:40 UTC (rev 260947)
@@ -1,3 +1,23 @@
+2020-04-30 Philippe Normand <[email protected]>
+
+ [SOUP] http/tests/media/video-accept-encoding.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=211228
+
+ Reviewed by Carlos Garcia Campos.
+
+ The resource requests received by the network process always had
+ the accept-encoding setting enabled due to lack of IPC
+ (de)serialization for this boolean.
+
+ The patch also enables soup release logging, set WEBKIT_DEBUG=Network=debug.
+
+ * platform/network/soup/ResourceRequest.h:
+ (WebCore::ResourceRequest::encodeWithPlatformData const):
+ (WebCore::ResourceRequest::decodeWithPlatformData):
+ * platform/network/soup/SoupNetworkSession.cpp:
+ (WebCore::soupLogPrinter):
+ (WebCore::SoupNetworkSession::setupLogger):
+
2020-04-30 Carlos Garcia Campos <[email protected]>
[GTK4][X11] Add support for rendering web view contents
Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequest.h (260946 => 260947)
--- trunk/Source/WebCore/platform/network/soup/ResourceRequest.h 2020-04-30 12:58:53 UTC (rev 260946)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequest.h 2020-04-30 13:38:40 UTC (rev 260947)
@@ -137,6 +137,7 @@
encoder << static_cast<uint32_t>(m_soupFlags);
encoder << m_initiatingPageID;
+ encoder << static_cast<bool>(m_acceptEncoding);
}
template<class Decoder>
@@ -166,6 +167,11 @@
return false;
m_initiatingPageID = *initiatingPageID;
+ bool acceptEncoding;
+ if (!decoder.decode(acceptEncoding))
+ return false;
+ m_acceptEncoding = acceptEncoding;
+
return true;
}
Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (260946 => 260947)
--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2020-04-30 12:58:53 UTC (rev 260946)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2020-04-30 13:38:40 UTC (rev 260947)
@@ -64,10 +64,14 @@
return directory.get();
}
-#if !LOG_DISABLED
+#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
inline static void soupLogPrinter(SoupLogger*, SoupLoggerLogLevel, char direction, const char* data, gpointer)
{
+#if !LOG_DISABLED
LOG(Network, "%c %s", direction, data);
+#elif !RELEASE_LOG_DISABLED
+ RELEASE_LOG(Network, "%c %s", direction, data);
+#endif
}
#endif
@@ -152,7 +156,7 @@
void SoupNetworkSession::setupLogger()
{
-#if !LOG_DISABLED
+#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
if (LogNetwork.state != WTFLogChannelState::On || soup_session_get_feature(m_soupSession.get(), SOUP_TYPE_LOGGER))
return;
Modified: trunk/Tools/ChangeLog (260946 => 260947)
--- trunk/Tools/ChangeLog 2020-04-30 12:58:53 UTC (rev 260946)
+++ trunk/Tools/ChangeLog 2020-04-30 13:38:40 UTC (rev 260947)
@@ -1,3 +1,15 @@
+2020-04-30 Philippe Normand <[email protected]>
+
+ [SOUP] http/tests/media/video-accept-encoding.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=211228
+
+ Reviewed by Carlos Garcia Campos.
+
+ * Scripts/webkitpy/port/gtk.py:
+ (GtkPort.setup_environ_for_server):
+ * Scripts/webkitpy/port/wpe.py:
+ (WPEPort.setup_environ_for_server):
+
2020-04-30 Andres Gonzalez <[email protected]>
Fix for crashes in accessibility/accessibility-node-memory-management.html in isolated tree mode.
Modified: trunk/Tools/Scripts/webkitpy/port/gtk.py (260946 => 260947)
--- trunk/Tools/Scripts/webkitpy/port/gtk.py 2020-04-30 12:58:53 UTC (rev 260946)
+++ trunk/Tools/Scripts/webkitpy/port/gtk.py 2020-04-30 13:38:40 UTC (rev 260947)
@@ -124,6 +124,7 @@
self._copy_value_from_environ_if_set(environment, 'WEBKIT_OUTPUTDIR')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_JHBUILD')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_TOP_LEVEL')
+ self._copy_value_from_environ_if_set(environment, 'WEBKIT_DEBUG')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_GST_USE_PLAYBIN3')
for gst_variable in ('DEBUG', 'DEBUG_DUMP_DOT_DIR', 'DEBUG_FILE', 'DEBUG_NO_COLOR',
'PLUGIN_SCANNER', 'PLUGIN_PATH', 'PLUGIN_SYSTEM_PATH', 'REGISTRY',
Modified: trunk/Tools/Scripts/webkitpy/port/wpe.py (260946 => 260947)
--- trunk/Tools/Scripts/webkitpy/port/wpe.py 2020-04-30 12:58:53 UTC (rev 260946)
+++ trunk/Tools/Scripts/webkitpy/port/wpe.py 2020-04-30 13:38:40 UTC (rev 260947)
@@ -79,6 +79,7 @@
self._copy_value_from_environ_if_set(environment, 'WEBKIT_OUTPUTDIR')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_JHBUILD')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_TOP_LEVEL')
+ self._copy_value_from_environ_if_set(environment, 'WEBKIT_DEBUG')
self._copy_value_from_environ_if_set(environment, 'LIBGL_ALWAYS_SOFTWARE')
self._copy_value_from_environ_if_set(environment, 'XR_RUNTIME_JSON')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_GST_USE_PLAYBIN3')
