Title: [260959] trunk/Tools
- Revision
- 260959
- Author
- [email protected]
- Date
- 2020-04-30 12:19:44 -0700 (Thu, 30 Apr 2020)
Log Message
REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m
<https://webkit.org/b/211243>
Reviewed by Tim Horton.
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate createBrowserWindowController:]):
- Autorelease return value to fix leak.
(-[BrowserAppDelegate newPrivateWindow:]):
- Release controller to fix leak.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (260958 => 260959)
--- trunk/Tools/ChangeLog 2020-04-30 19:01:30 UTC (rev 260958)
+++ trunk/Tools/ChangeLog 2020-04-30 19:19:44 UTC (rev 260959)
@@ -1,5 +1,18 @@
2020-04-30 David Kilzer <[email protected]>
+ REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m
+ <https://webkit.org/b/211243>
+
+ Reviewed by Tim Horton.
+
+ * MiniBrowser/mac/AppDelegate.m:
+ (-[BrowserAppDelegate createBrowserWindowController:]):
+ - Autorelease return value to fix leak.
+ (-[BrowserAppDelegate newPrivateWindow:]):
+ - Release controller to fix leak.
+
+2020-04-30 David Kilzer <[email protected]>
+
REGRESSION (r247490): Leak of MiniBrowserNSTextFinder._hideInterfaceCallback
<https://webkit.org/b/211242>
Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (260958 => 260959)
--- trunk/Tools/MiniBrowser/mac/AppDelegate.m 2020-04-30 19:01:30 UTC (rev 260958)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m 2020-04-30 19:19:44 UTC (rev 260959)
@@ -183,7 +183,7 @@
[_browserWindowControllers addObject:controller];
- return controller;
+ return [controller autorelease];
}
- (IBAction)newWindow:(id)sender
@@ -208,6 +208,7 @@
[_browserWindowControllers addObject:controller];
[controller loadURLString:_settingsController.defaultURL];
+ [controller release];
}
- (IBAction)newEditorWindow:(id)sender
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
