Title: [260969] trunk/Source/WebCore
- Revision
- 260969
- Author
- [email protected]
- Date
- 2020-04-30 14:58:08 -0700 (Thu, 30 Apr 2020)
Log Message
clearApplicationBundleIdentifierTestingOverride() should set the bundle identifier to a null string, not an empty string
https://bugs.webkit.org/show_bug.cgi?id=211255
<rdar://problem/62651110>
Reviewed by John Wilander.
No new tests, behavior confirmed by existing tests.
Clearing the bundle identifier during tests should reset the override
value to be a null string so that the following calls to applicationBundleIdentifier()
use the [NSBundle mainBundle] bundleIdentifier] call.
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::clearApplicationBundleIdentifierTestingOverride):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (260968 => 260969)
--- trunk/Source/WebCore/ChangeLog 2020-04-30 21:39:06 UTC (rev 260968)
+++ trunk/Source/WebCore/ChangeLog 2020-04-30 21:58:08 UTC (rev 260969)
@@ -1,3 +1,20 @@
+2020-04-30 Kate Cheney <[email protected]>
+
+ clearApplicationBundleIdentifierTestingOverride() should set the bundle identifier to a null string, not an empty string
+ https://bugs.webkit.org/show_bug.cgi?id=211255
+ <rdar://problem/62651110>
+
+ Reviewed by John Wilander.
+
+ No new tests, behavior confirmed by existing tests.
+
+ Clearing the bundle identifier during tests should reset the override
+ value to be a null string so that the following calls to applicationBundleIdentifier()
+ use the [NSBundle mainBundle] bundleIdentifier] call.
+
+ * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+ (WebCore::clearApplicationBundleIdentifierTestingOverride):
+
2020-04-30 Devin Rousso <[email protected]>
WebKit.WebContent process crashes when web developer tools are opened in Safari
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (260968 => 260969)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-04-30 21:39:06 UTC (rev 260968)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-04-30 21:58:08 UTC (rev 260969)
@@ -69,7 +69,7 @@
void clearApplicationBundleIdentifierTestingOverride()
{
ASSERT(RunLoop::isMain());
- applicationBundleIdentifierOverride() = emptyString();
+ applicationBundleIdentifierOverride() = String();
#if !ASSERT_MSG_DISABLED
applicationBundleIdentifierOverrideWasQueried = false;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
