Title: [260980] trunk/Source/WebKit
- Revision
- 260980
- Author
- [email protected]
- Date
- 2020-04-30 20:26:21 -0700 (Thu, 30 Apr 2020)
Log Message
[iOS] Fix confusing idiom for releasing _selectionRects in -[WKTextRange dealloc]
<https://webkit.org/b/211269>
Reviewed by Wenson Hsieh.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKTextRange dealloc]):
- Switch to more common idiom to release an instance variable.
This fixes a false positive warning from the clang static
analyzer about releasing a variable not owned by the caller.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260979 => 260980)
--- trunk/Source/WebKit/ChangeLog 2020-05-01 03:01:09 UTC (rev 260979)
+++ trunk/Source/WebKit/ChangeLog 2020-05-01 03:26:21 UTC (rev 260980)
@@ -1,3 +1,16 @@
+2020-04-30 David Kilzer <[email protected]>
+
+ [iOS] Fix confusing idiom for releasing _selectionRects in -[WKTextRange dealloc]
+ <https://webkit.org/b/211269>
+
+ Reviewed by Wenson Hsieh.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKTextRange dealloc]):
+ - Switch to more common idiom to release an instance variable.
+ This fixes a false positive warning from the clang static
+ analyzer about releasing a variable not owned by the caller.
+
2020-04-30 Wenson Hsieh <[email protected]>
REGRESSION: Double tap dispatches one click event on iOS 13.4 when it would dispatch two on iOS 13.3
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (260979 => 260980)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-05-01 03:01:09 UTC (rev 260979)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-05-01 03:26:21 UTC (rev 260980)
@@ -9752,7 +9752,7 @@
- (void)dealloc
{
- [self.selectionRects release];
+ [_selectionRects release];
[super dealloc];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
