Title: [260986] trunk/Source
- Revision
- 260986
- Author
- [email protected]
- Date
- 2020-05-01 01:08:12 -0700 (Fri, 01 May 2020)
Log Message
[GTK4] Disable arrow on context menu popover
https://bugs.webkit.org/show_bug.cgi?id=211241
Reviewed by Carlos Garcia Campos.
Source/WebCore:
No new tests needed.
* platform/gtk/GtkVersioning.h:
(gdk_display_get_monitor_at_window): Add no-op stub for GTK3.
Source/WebKit:
* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Disable the menu popover arrow.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (260985 => 260986)
--- trunk/Source/WebCore/ChangeLog 2020-05-01 06:50:54 UTC (rev 260985)
+++ trunk/Source/WebCore/ChangeLog 2020-05-01 08:08:12 UTC (rev 260986)
@@ -1,3 +1,15 @@
+2020-05-01 Adrian Perez de Castro <[email protected]>
+
+ [GTK4] Disable arrow on context menu popover
+ https://bugs.webkit.org/show_bug.cgi?id=211241
+
+ Reviewed by Carlos Garcia Campos.
+
+ No new tests needed.
+
+ * platform/gtk/GtkVersioning.h:
+ (gdk_display_get_monitor_at_window): Add no-op stub for GTK3.
+
2020-04-30 Rob Buis <[email protected]>
Inline reportBlockedPortFailed and reportAuthenticationChallengeBlocked
Modified: trunk/Source/WebCore/platform/gtk/GtkVersioning.h (260985 => 260986)
--- trunk/Source/WebCore/platform/gtk/GtkVersioning.h 2020-05-01 06:50:54 UTC (rev 260985)
+++ trunk/Source/WebCore/platform/gtk/GtkVersioning.h 2020-05-01 08:08:12 UTC (rev 260986)
@@ -167,4 +167,11 @@
{
gtk_widget_set_parent(GTK_WIDGET(popover), parent);
}
+
+#else
+
+static inline void gtk_popover_set_has_arrow(GtkPopover*, gboolean)
+{
+}
+
#endif // USE(GTK4)
Modified: trunk/Source/WebKit/ChangeLog (260985 => 260986)
--- trunk/Source/WebKit/ChangeLog 2020-05-01 06:50:54 UTC (rev 260985)
+++ trunk/Source/WebKit/ChangeLog 2020-05-01 08:08:12 UTC (rev 260986)
@@ -1,3 +1,13 @@
+2020-05-01 Adrian Perez de Castro <[email protected]>
+
+ [GTK4] Disable arrow on context menu popover
+ https://bugs.webkit.org/show_bug.cgi?id=211241
+
+ Reviewed by Carlos Garcia Campos.
+
+ * UIProcess/gtk/WebContextMenuProxyGtk.cpp:
+ (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Disable the menu popover arrow.
+
2020-04-30 Ross Kirsling <[email protected]>
TriState should be an enum class and use "Indeterminate" instead of "Mixed"
Modified: trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp (260985 => 260986)
--- trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp 2020-05-01 06:50:54 UTC (rev 260985)
+++ trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp 2020-05-01 08:08:12 UTC (rev 260986)
@@ -191,6 +191,7 @@
, m_page(&page)
, m_menu(GTK_POPOVER(gtk_popover_menu_new()))
{
+ gtk_popover_set_has_arrow(m_menu, FALSE);
gtk_popover_set_position(m_menu, GTK_POS_BOTTOM);
gtk_popover_set_relative_to(m_menu, m_webView);
gtk_widget_insert_action_group(GTK_WIDGET(m_menu), gContextMenuItemGroup, G_ACTION_GROUP(m_actionGroup.get()));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
