Title: [261080] trunk/Source/WebCore
Revision
261080
Author
[email protected]
Date
2020-05-04 07:13:24 -0700 (Mon, 04 May 2020)

Log Message

Camera video samples have a bad orientation if upside down
https://bugs.webkit.org/show_bug.cgi?id=211373

Reviewed by Eric Carlson.

Manually tested on iPad and iPhones.

* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::computeSampleRotation):
-90 should be the same as 270 not -270.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (261079 => 261080)


--- trunk/Source/WebCore/ChangeLog	2020-05-04 08:57:33 UTC (rev 261079)
+++ trunk/Source/WebCore/ChangeLog	2020-05-04 14:13:24 UTC (rev 261080)
@@ -1,3 +1,16 @@
+2020-05-04  Youenn Fablet  <[email protected]>
+
+        Camera video samples have a bad orientation if upside down
+        https://bugs.webkit.org/show_bug.cgi?id=211373
+
+        Reviewed by Eric Carlson.
+
+        Manually tested on iPad and iPhones.
+
+        * platform/mediastream/mac/AVVideoCaptureSource.mm:
+        (WebCore::AVVideoCaptureSource::computeSampleRotation):
+        -90 should be the same as 270 not -270.
+
 2020-05-04  Yusuke Suzuki  <[email protected]>
 
         [gtk] isMainThread() assert when running minibrowser in debug builds.

Modified: trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm (261079 => 261080)


--- trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm	2020-05-04 08:57:33 UTC (rev 261079)
+++ trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm	2020-05-04 14:13:24 UTC (rev 261080)
@@ -525,10 +525,11 @@
         sampleRotation = MediaSample::VideoRotation::UpsideDown;
         break;
     case 90:
+    case -270:
         sampleRotation = frontCamera ? MediaSample::VideoRotation::Left : MediaSample::VideoRotation::Right;
         break;
     case -90:
-    case -270:
+    case 270:
         sampleRotation = frontCamera ? MediaSample::VideoRotation::Right : MediaSample::VideoRotation::Left;
         break;
     default:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to