Title: [261087] trunk/Tools
Revision
261087
Author
[email protected]
Date
2020-05-04 08:58:53 -0700 (Mon, 04 May 2020)

Log Message

[WPE][GTK] Should install python3-secretstorage
https://bugs.webkit.org/show_bug.cgi?id=207473

Patch by Michael Catanzaro <[email protected]> on 2020-05-04
Reviewed by Adrian Perez de Castro.

If python3-secretstorage is not installed, webkit-patch will use a custom encrypted file
for password storage instead of utilizing the system keyring. This means unnecessary
password prompts to unlock the custom encrypted key storage.

There is no benefit to using custom key storage over the system keyring.

* gtk/install-dependencies:
* wpe/install-dependencies:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (261086 => 261087)


--- trunk/Tools/ChangeLog	2020-05-04 15:46:18 UTC (rev 261086)
+++ trunk/Tools/ChangeLog	2020-05-04 15:58:53 UTC (rev 261087)
@@ -1,3 +1,19 @@
+2020-05-04  Michael Catanzaro  <[email protected]>
+
+        [WPE][GTK] Should install python3-secretstorage
+        https://bugs.webkit.org/show_bug.cgi?id=207473
+
+        Reviewed by Adrian Perez de Castro.
+
+        If python3-secretstorage is not installed, webkit-patch will use a custom encrypted file
+        for password storage instead of utilizing the system keyring. This means unnecessary
+        password prompts to unlock the custom encrypted key storage.
+
+        There is no benefit to using custom key storage over the system keyring.
+
+        * gtk/install-dependencies:
+        * wpe/install-dependencies:
+
 2020-05-04  Andres Gonzalez  <[email protected]>
 
         Add WTR::AccessibilityUIElement::attributeValueAsync to retrieve attribute values in isolated tree mode.

Modified: trunk/Tools/gtk/install-dependencies (261086 => 261087)


--- trunk/Tools/gtk/install-dependencies	2020-05-04 15:46:18 UTC (rev 261086)
+++ trunk/Tools/gtk/install-dependencies	2020-05-04 15:58:53 UTC (rev 261087)
@@ -246,6 +246,7 @@
     # These are dependencies necessary for using webkit-patch
     packages="$packages \
         git-svn \
+        python3-secretstorage \
         subversion"
 
     apt-get install $packages
@@ -412,6 +413,7 @@
 
     # These are dependencies necessary for using webkit-patch
     packages="$packages \
+        python-secretstorage \
         svn"
     pacman -S --needed $packages
 
@@ -584,6 +586,7 @@
     # These are dependencies necessary for using webkit-patch
     packages="$packages
         git-svn \
+        python3-secretstorage \
         subversion"
 
     dnf install $packages

Modified: trunk/Tools/wpe/install-dependencies (261086 => 261087)


--- trunk/Tools/wpe/install-dependencies	2020-05-04 15:46:18 UTC (rev 261086)
+++ trunk/Tools/wpe/install-dependencies	2020-05-04 15:58:53 UTC (rev 261087)
@@ -149,6 +149,7 @@
     # These are dependencies necessary for using webkit-patch
     packages="$packages \
         git-svn \
+        python3-secretstorage \
         subversion"
 
     apt-get install $packages
@@ -254,6 +255,7 @@
 
     # These are dependencies necessary for using webkit-patch
     packages="$packages \
+        python-secretstorage \
         svn"
     pacman -S --needed $packages
 
@@ -375,6 +377,7 @@
     # These are dependencies necessary for using webkit-patch
     packages="$packages
         git-svn \
+        python3-secretstorage \
         subversion"
 
     dnf install $packages
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to