Title: [261114] trunk/Source/WebKit
Revision
261114
Author
[email protected]
Date
2020-05-04 14:58:29 -0700 (Mon, 04 May 2020)

Log Message

Reduce AlternativeService assertion to debug-only assert
https://bugs.webkit.org/show_bug.cgi?id=211263
<rdar://problem/61354813>

Patch by Alex Christensen <[email protected]> on 2020-05-04
Reviewed by Chris Dumez.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
This is asserting sometimes.  No need to crash.  Reduce to debug-only assert.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (261113 => 261114)


--- trunk/Source/WebKit/ChangeLog	2020-05-04 21:24:49 UTC (rev 261113)
+++ trunk/Source/WebKit/ChangeLog	2020-05-04 21:58:29 UTC (rev 261114)
@@ -1,3 +1,15 @@
+2020-05-04  Alex Christensen  <[email protected]>
+
+        Reduce AlternativeService assertion to debug-only assert
+        https://bugs.webkit.org/show_bug.cgi?id=211263
+        <rdar://problem/61354813>
+
+        Reviewed by Chris Dumez.
+
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+        This is asserting sometimes.  No need to crash.  Reduce to debug-only assert.
+
 2020-05-04  Said Abou-Hallawa  <[email protected]>
 
         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler

Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (261113 => 261114)


--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2020-05-04 21:24:49 UTC (rev 261113)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2020-05-04 21:58:29 UTC (rev 261114)
@@ -1169,7 +1169,7 @@
         SandboxExtension::consumePermanently(parameters.alternativeServiceDirectoryExtensionHandle);
         configuration._alternativeServicesStorage = [[[_NSHTTPAlternativeServicesStorage alloc] initPersistentStoreWithURL:[[NSURL fileURLWithPath:parameters.alternativeServiceDirectory isDirectory:YES] URLByAppendingPathComponent:@"AlternativeService.sqlite"]] autorelease];
     } else
-        RELEASE_ASSERT(m_sessionID.isEphemeral());
+        ASSERT(m_sessionID.isEphemeral());
     configuration._allowsHTTP3 = parameters.http3Enabled;
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to