Title: [261125] trunk
- Revision
- 261125
- Author
- [email protected]
- Date
- 2020-05-04 16:37:44 -0700 (Mon, 04 May 2020)
Log Message
[JSC] Add @@toStringTag to WebAssembly.Global
https://bugs.webkit.org/show_bug.cgi?id=211372
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
* web-platform-tests/wasm/jsapi/global/toString.any-expected.txt:
* web-platform-tests/wasm/jsapi/global/toString.any.worker-expected.txt:
Source/_javascript_Core:
As r260992 did for the other wasm prototypes, we should put @@toStringTag to WebAssembly.Global's prototype too.
* wasm/js/WebAssemblyGlobalPrototype.cpp:
(JSC::WebAssemblyGlobalPrototype::finishCreation):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (261124 => 261125)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-04 23:25:08 UTC (rev 261124)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-04 23:37:44 UTC (rev 261125)
@@ -1,3 +1,13 @@
+2020-05-04 Yusuke Suzuki <[email protected]>
+
+ [JSC] Add @@toStringTag to WebAssembly.Global
+ https://bugs.webkit.org/show_bug.cgi?id=211372
+
+ Reviewed by Sam Weinig.
+
+ * web-platform-tests/wasm/jsapi/global/toString.any-expected.txt:
+ * web-platform-tests/wasm/jsapi/global/toString.any.worker-expected.txt:
+
2020-05-04 Emilio Cobos Álvarez <[email protected]>
Put lh / rlh units behind a flag until bug 211351 is sorted out.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/toString.any-expected.txt (261124 => 261125)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/toString.any-expected.txt 2020-05-04 23:25:08 UTC (rev 261124)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/toString.any-expected.txt 2020-05-04 23:37:44 UTC (rev 261125)
@@ -1,4 +1,4 @@
PASS Object.prototype.toString on an Global
-FAIL @@toStringTag exists on the prototype with the appropriate descriptor assert_own_property: expected property symbol "Symbol(Symbol.toStringTag)" missing
+PASS @@toStringTag exists on the prototype with the appropriate descriptor
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/toString.any.worker-expected.txt (261124 => 261125)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/toString.any.worker-expected.txt 2020-05-04 23:25:08 UTC (rev 261124)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/toString.any.worker-expected.txt 2020-05-04 23:37:44 UTC (rev 261125)
@@ -1,4 +1,4 @@
PASS Object.prototype.toString on an Global
-FAIL @@toStringTag exists on the prototype with the appropriate descriptor assert_own_property: expected property symbol "Symbol(Symbol.toStringTag)" missing
+PASS @@toStringTag exists on the prototype with the appropriate descriptor
Modified: trunk/Source/_javascript_Core/ChangeLog (261124 => 261125)
--- trunk/Source/_javascript_Core/ChangeLog 2020-05-04 23:25:08 UTC (rev 261124)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-05-04 23:37:44 UTC (rev 261125)
@@ -1,3 +1,15 @@
+2020-05-04 Yusuke Suzuki <[email protected]>
+
+ [JSC] Add @@toStringTag to WebAssembly.Global
+ https://bugs.webkit.org/show_bug.cgi?id=211372
+
+ Reviewed by Sam Weinig.
+
+ As r260992 did for the other wasm prototypes, we should put @@toStringTag to WebAssembly.Global's prototype too.
+
+ * wasm/js/WebAssemblyGlobalPrototype.cpp:
+ (JSC::WebAssemblyGlobalPrototype::finishCreation):
+
2020-05-04 Devin Rousso <[email protected]>
Web Inspector: Worker: should use the name of the worker if it exists
Modified: trunk/Source/_javascript_Core/wasm/js/WebAssemblyGlobalPrototype.cpp (261124 => 261125)
--- trunk/Source/_javascript_Core/wasm/js/WebAssemblyGlobalPrototype.cpp 2020-05-04 23:25:08 UTC (rev 261124)
+++ trunk/Source/_javascript_Core/wasm/js/WebAssemblyGlobalPrototype.cpp 2020-05-04 23:37:44 UTC (rev 261125)
@@ -143,6 +143,7 @@
JSFunction* valueSetterFunction = JSFunction::create(vm, globalObject, 1, "set value"_s, webAssemblyGlobalProtoSetterFuncValue, NoIntrinsic);
GetterSetter* valueAccessor = GetterSetter::create(vm, globalObject, valueGetterFunction, valueSetterFunction);
putDirectNonIndexAccessorWithoutTransition(vm, Identifier::fromString(vm, "value"_s), valueAccessor, static_cast<unsigned>(PropertyAttribute::Accessor));
+ JSC_TO_STRING_TAG_WITHOUT_TRANSITION();
}
WebAssemblyGlobalPrototype::WebAssemblyGlobalPrototype(VM& vm, Structure* structure)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
