Title: [261129] trunk/Source/WebKit
- Revision
- 261129
- Author
- [email protected]
- Date
- 2020-05-04 17:24:31 -0700 (Mon, 04 May 2020)
Log Message
Use default constructor and default initializer for SecItemRequestData
<https://webkit.org/b/211399>
<rdar://problem/62861551>
Reviewed by Darin Adler.
* Shared/mac/SecItemRequestData.cpp:
- Remove default constructor implementation.
* Shared/mac/SecItemRequestData.h:
- Use default constructor for class.
- Use default initializer for m_type.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (261128 => 261129)
--- trunk/Source/WebKit/ChangeLog 2020-05-05 00:09:04 UTC (rev 261128)
+++ trunk/Source/WebKit/ChangeLog 2020-05-05 00:24:31 UTC (rev 261129)
@@ -1,3 +1,17 @@
+2020-05-04 David Kilzer <[email protected]>
+
+ Use default constructor and default initializer for SecItemRequestData
+ <https://webkit.org/b/211399>
+ <rdar://problem/62861551>
+
+ Reviewed by Darin Adler.
+
+ * Shared/mac/SecItemRequestData.cpp:
+ - Remove default constructor implementation.
+ * Shared/mac/SecItemRequestData.h:
+ - Use default constructor for class.
+ - Use default initializer for m_type.
+
2020-05-04 Brent Fulgham <[email protected]>
REGRESSION (r259470): Accessibility Stereo to Mono is not working
Modified: trunk/Source/WebKit/Shared/mac/SecItemRequestData.cpp (261128 => 261129)
--- trunk/Source/WebKit/Shared/mac/SecItemRequestData.cpp 2020-05-05 00:09:04 UTC (rev 261128)
+++ trunk/Source/WebKit/Shared/mac/SecItemRequestData.cpp 2020-05-05 00:24:31 UTC (rev 261129)
@@ -31,11 +31,6 @@
namespace WebKit {
-SecItemRequestData::SecItemRequestData()
- : m_type(Invalid)
-{
-}
-
SecItemRequestData::SecItemRequestData(Type type, CFDictionaryRef query)
: m_type(type)
, m_queryDictionary(query)
Modified: trunk/Source/WebKit/Shared/mac/SecItemRequestData.h (261128 => 261129)
--- trunk/Source/WebKit/Shared/mac/SecItemRequestData.h 2020-05-05 00:09:04 UTC (rev 261128)
+++ trunk/Source/WebKit/Shared/mac/SecItemRequestData.h 2020-05-05 00:24:31 UTC (rev 261129)
@@ -45,7 +45,7 @@
Delete,
};
- SecItemRequestData();
+ SecItemRequestData() = default;
SecItemRequestData(Type, CFDictionaryRef query);
SecItemRequestData(Type, CFDictionaryRef query, CFDictionaryRef attributesToMatch);
@@ -58,7 +58,7 @@
CFDictionaryRef attributesToMatch() const { return m_attributesToMatch.get(); }
private:
- Type m_type;
+ Type m_type { Invalid };
RetainPtr<CFDictionaryRef> m_queryDictionary;
RetainPtr<CFDictionaryRef> m_attributesToMatch;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
