Title: [261228] trunk/Source
- Revision
- 261228
- Author
- da...@apple.com
- Date
- 2020-05-06 08:00:50 -0700 (Wed, 06 May 2020)
Log Message
Reduce HAVE(HOSTED_CORE_ANIMATION)
https://bugs.webkit.org/show_bug.cgi?id=211423
Reviewed by Anders Carlsson.
Source/WebKit:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess): Removed redundant #if
checking both HAVE(HOSTED_CORE_ANIMATION) and !PLATFORM(IOS_FAMILY).
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess): Removed unnecessary
HAVE(HOSTED_CORE_ANIMATION) check in code that is only compiled for macOS.
Source/WTF:
* wtf/PlatformHave.h: Simplified conditional to just PLATFORM(MAC)
for HOSTED_CORE_ANIMATION.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (261227 => 261228)
--- trunk/Source/WTF/ChangeLog 2020-05-06 14:30:45 UTC (rev 261227)
+++ trunk/Source/WTF/ChangeLog 2020-05-06 15:00:50 UTC (rev 261228)
@@ -1,3 +1,13 @@
+2020-05-06 Darin Adler <da...@apple.com>
+
+ Reduce HAVE(HOSTED_CORE_ANIMATION)
+ https://bugs.webkit.org/show_bug.cgi?id=211423
+
+ Reviewed by Anders Carlsson.
+
+ * wtf/PlatformHave.h: Simplified conditional to just PLATFORM(MAC)
+ for HOSTED_CORE_ANIMATION.
+
2020-05-05 Darin Adler <da...@apple.com>
Remove HAVE(AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT)
Modified: trunk/Source/WTF/wtf/PlatformHave.h (261227 => 261228)
--- trunk/Source/WTF/wtf/PlatformHave.h 2020-05-06 14:30:45 UTC (rev 261227)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2020-05-06 15:00:50 UTC (rev 261228)
@@ -212,7 +212,7 @@
#define HAVE_MACH_EXCEPTIONS 1
#endif
-#if OS(DARWIN) && !PLATFORM(IOS_FAMILY)
+#if PLATFORM(MAC)
#define HAVE_HOSTED_CORE_ANIMATION 1
#endif
Modified: trunk/Source/WebKit/ChangeLog (261227 => 261228)
--- trunk/Source/WebKit/ChangeLog 2020-05-06 14:30:45 UTC (rev 261227)
+++ trunk/Source/WebKit/ChangeLog 2020-05-06 15:00:50 UTC (rev 261228)
@@ -1,3 +1,18 @@
+2020-05-06 Darin Adler <da...@apple.com>
+
+ Reduce HAVE(HOSTED_CORE_ANIMATION)
+ https://bugs.webkit.org/show_bug.cgi?id=211423
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::platformInitializeWebProcess): Removed redundant #if
+ checking both HAVE(HOSTED_CORE_ANIMATION) and !PLATFORM(IOS_FAMILY).
+
+ * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
+ (WebKit::PluginProcessProxy::platformInitializePluginProcess): Removed unnecessary
+ HAVE(HOSTED_CORE_ANIMATION) check in code that is only compiled for macOS.
+
2020-05-05 David Kilzer <ddkil...@apple.com>
Fix deprecated NSGraphicsContext methods using 'graphicsPort'
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (261227 => 261228)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-05-06 14:30:45 UTC (rev 261227)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-05-06 15:00:50 UTC (rev 261228)
@@ -298,10 +298,8 @@
parameters.shouldSuppressMemoryPressureHandler = [defaults boolForKey:WebKitSuppressMemoryPressureHandlerDefaultsKey];
#if HAVE(HOSTED_CORE_ANIMATION)
-#if !PLATFORM(IOS_FAMILY)
parameters.acceleratedCompositingPort = MachSendRight::create([CARemoteLayerServer sharedServer].serverPort);
#endif
-#endif
// FIXME: This should really be configurable; we shouldn't just blindly allow read access to the UI process bundle.
parameters.uiProcessBundleResourcePath = m_resolvedPaths.uiProcessBundleResourcePath;
Modified: trunk/Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm (261227 => 261228)
--- trunk/Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm 2020-05-06 14:30:45 UTC (rev 261227)
+++ trunk/Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm 2020-05-06 15:00:50 UTC (rev 261228)
@@ -82,9 +82,7 @@
// For now only Flash is known to behave with asynchronous plug-in initialization.
parameters.supportsAsynchronousPluginInitialization = m_pluginProcessAttributes.moduleInfo.bundleIdentifier == "com.macromedia.Flash Player.plugin";
-#if HAVE(HOSTED_CORE_ANIMATION)
parameters.acceleratedCompositingPort = MachSendRight::create([CARemoteLayerServer sharedServer].serverPort);
-#endif
parameters.networkATSContext = adoptCF(_CFNetworkCopyATSContext());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
