Title: [261236] trunk/LayoutTests
- Revision
- 261236
- Author
- [email protected]
- Date
- 2020-05-06 09:30:35 -0700 (Wed, 06 May 2020)
Log Message
fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS
https://bugs.webkit.org/show_bug.cgi?id=211515
<rdar://problem/61180247>
Reviewed by Darin Adler.
Update test to navigate to fast/history/resources/page-cache-helper.html instead of
a data URL which calls history.back() on load. Unlike the data URL, page-cache-helper.html
only navigates back in a 0-timer after the load event has fired. This is important to
guarantee that the current history item has been created before navigating back. If we
navigate back too early, then the current history item is still the one for the previous
page and we end up navigating back to the previous test, which would cause the timeout.
* fast/overflow/horizontal-scroll-after-back.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (261235 => 261236)
--- trunk/LayoutTests/ChangeLog 2020-05-06 16:29:03 UTC (rev 261235)
+++ trunk/LayoutTests/ChangeLog 2020-05-06 16:30:35 UTC (rev 261236)
@@ -1,3 +1,20 @@
+2020-05-06 Chris Dumez <[email protected]>
+
+ fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS
+ https://bugs.webkit.org/show_bug.cgi?id=211515
+ <rdar://problem/61180247>
+
+ Reviewed by Darin Adler.
+
+ Update test to navigate to fast/history/resources/page-cache-helper.html instead of
+ a data URL which calls history.back() on load. Unlike the data URL, page-cache-helper.html
+ only navigates back in a 0-timer after the load event has fired. This is important to
+ guarantee that the current history item has been created before navigating back. If we
+ navigate back too early, then the current history item is still the one for the previous
+ page and we end up navigating back to the previous test, which would cause the timeout.
+
+ * fast/overflow/horizontal-scroll-after-back.html:
+
2020-05-06 Alexey Shvayka <[email protected]>
Remove orphaned WPT expectations & unused harness
Modified: trunk/LayoutTests/fast/overflow/horizontal-scroll-after-back.html (261235 => 261236)
--- trunk/LayoutTests/fast/overflow/horizontal-scroll-after-back.html 2020-05-06 16:29:03 UTC (rev 261235)
+++ trunk/LayoutTests/fast/overflow/horizontal-scroll-after-back.html 2020-05-06 16:30:35 UTC (rev 261236)
@@ -63,6 +63,6 @@
</style>
</head>
<body _onload_='runTestStep()'>
-<div id="content"> <a id='anchor' href=''>Where is the scrollbar?</a></div>
+<div id="content"> <a id='anchor' href=''>Where is the scrollbar?</a></div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
