Title: [261263] trunk/Source/WebKit
- Revision
- 261263
- Author
- commit-qu...@webkit.org
- Date
- 2020-05-06 19:13:43 -0700 (Wed, 06 May 2020)
Log Message
Unreviewed, reverting r260689.
https://bugs.webkit.org/show_bug.cgi?id=211542
"Caused regressions deleting text and filling password fields"
(Requested by ddkilzer on #webkit).
Reverted changeset:
"WebPasteboardProxy::getPasteboardStringsForType() and
WebPasteboardProxy::readURLFromPasteboard() should check
return value of SharedMemory::createHandle()"
https://bugs.webkit.org/show_bug.cgi?id=211002
https://trac.webkit.org/changeset/260689
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (261262 => 261263)
--- trunk/Source/WebKit/ChangeLog 2020-05-07 00:27:33 UTC (rev 261262)
+++ trunk/Source/WebKit/ChangeLog 2020-05-07 02:13:43 UTC (rev 261263)
@@ -1,3 +1,19 @@
+2020-05-06 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, reverting r260689.
+ https://bugs.webkit.org/show_bug.cgi?id=211542
+
+ "Caused regressions deleting text and filling password fields"
+ (Requested by ddkilzer on #webkit).
+
+ Reverted changeset:
+
+ "WebPasteboardProxy::getPasteboardStringsForType() and
+ WebPasteboardProxy::readURLFromPasteboard() should check
+ return value of SharedMemory::createHandle()"
+ https://bugs.webkit.org/show_bug.cgi?id=211002
+ https://trac.webkit.org/changeset/260689
+
2020-05-06 Zalan Bujtas <za...@apple.com>
[ContentObservation] Shutterstock search bar is not activated on the first tap
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm (261262 => 261263)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm 2020-05-07 00:27:33 UTC (rev 261262)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm 2020-05-07 02:13:43 UTC (rev 261263)
@@ -212,8 +212,7 @@
return completionHandler({ }, 0);
memcpy(sharedMemoryBuffer->data(), buffer->data(), size);
SharedMemory::Handle handle;
- if (!sharedMemoryBuffer->createHandle(handle, SharedMemory::Protection::ReadOnly))
- return completionHandler({ }, 0);
+ sharedMemoryBuffer->createHandle(handle, SharedMemory::Protection::ReadOnly);
completionHandler(WTFMove(handle), size);
}
@@ -433,8 +432,7 @@
return completionHandler({ }, 0);
memcpy(sharedMemoryBuffer->data(), buffer->data(), size);
SharedMemory::Handle handle;
- if (!sharedMemoryBuffer->createHandle(handle, SharedMemory::Protection::ReadOnly))
- return completionHandler({ }, 0);
+ sharedMemoryBuffer->createHandle(handle, SharedMemory::Protection::ReadOnly);
completionHandler(WTFMove(handle), size);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
