Diff
Modified: trunk/JSTests/ChangeLog (261270 => 261271)
--- trunk/JSTests/ChangeLog 2020-05-07 06:36:12 UTC (rev 261270)
+++ trunk/JSTests/ChangeLog 2020-05-07 07:00:17 UTC (rev 261271)
@@ -1,3 +1,18 @@
+2020-05-07 Mark Lam <[email protected]>
+
+ Fix broken exceptionFuzz tests.
+ https://bugs.webkit.org/show_bug.cgi?id=211550
+
+ Reviewed by Yusuke Suzuki.
+
+ The tests should not be relying on setting a JSC Option at runtime because the
+ options are already frozen by then. Instead, we set the needed
+ --useExceptionFuzz=true option from the command line.
+
+ * exceptionFuzz/3d-cube.js:
+ * exceptionFuzz/date-format-xparb.js:
+ * exceptionFuzz/earley-boyer.js:
+
2020-05-06 Keith Miller <[email protected]>
DFG ByVal nodes with ArrayModes should clobberTop until Fixup phase runs.
Modified: trunk/JSTests/exceptionFuzz/3d-cube.js (261270 => 261271)
--- trunk/JSTests/exceptionFuzz/3d-cube.js 2020-05-07 06:36:12 UTC (rev 261270)
+++ trunk/JSTests/exceptionFuzz/3d-cube.js 2020-05-07 07:00:17 UTC (rev 261271)
@@ -1,5 +1,3 @@
-var enableExceptionFuzz = $vm.enableExceptionFuzz;
-
try {
// 3D Cube Rotation
@@ -6,9 +4,6 @@
// http://www.speich.net/computer/moztesting/3d.htm
// Created by Simon Speich
-enableExceptionFuzz();
-
-
var Q = new Array();
var MTrans = new Array(); // transformation matrix
var MQube = new Array(); // position information of qube
Modified: trunk/JSTests/exceptionFuzz/date-format-xparb.js (261270 => 261271)
--- trunk/JSTests/exceptionFuzz/date-format-xparb.js 2020-05-07 06:36:12 UTC (rev 261270)
+++ trunk/JSTests/exceptionFuzz/date-format-xparb.js 2020-05-07 07:00:17 UTC (rev 261271)
@@ -1,5 +1,3 @@
-var enableExceptionFuzz = $vm.enableExceptionFuzz;
-
try {
/*
@@ -15,9 +13,6 @@
* details.
*/
-enableExceptionFuzz();
-
-
Date.parseFunctions = {count:0};
Date.parseRegexes = [];
Date.formatFunctions = {count:0};
Modified: trunk/JSTests/exceptionFuzz/earley-boyer.js (261270 => 261271)
--- trunk/JSTests/exceptionFuzz/earley-boyer.js 2020-05-07 06:36:12 UTC (rev 261270)
+++ trunk/JSTests/exceptionFuzz/earley-boyer.js 2020-05-07 07:00:17 UTC (rev 261271)
@@ -1,5 +1,3 @@
-var enableExceptionFuzz = $vm.enableExceptionFuzz;
-
try {
// This file is automatically generated by scheme2js, except for the
// benchmark harness code at the beginning and end of the file.
@@ -41,9 +39,6 @@
}
*/
-enableExceptionFuzz();
-
-
function sc_print_debug() {
sc_print.apply(null, arguments);
}
Modified: trunk/Source/_javascript_Core/ChangeLog (261270 => 261271)
--- trunk/Source/_javascript_Core/ChangeLog 2020-05-07 06:36:12 UTC (rev 261270)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-05-07 07:00:17 UTC (rev 261271)
@@ -1,3 +1,16 @@
+2020-05-07 Mark Lam <[email protected]>
+
+ Fix broken exceptionFuzz tests.
+ https://bugs.webkit.org/show_bug.cgi?id=211550
+
+ Reviewed by Yusuke Suzuki.
+
+ Remove the bad and now unused utility function to set Options::useExceptionFuzz().
+
+ * tools/JSDollarVM.cpp:
+ (JSC::JSDollarVM::finishCreation):
+ (JSC::functionEnableExceptionFuzz): Deleted.
+
2020-05-06 Keith Miller <[email protected]>
DFG ByVal nodes with ArrayModes should clobberTop until Fixup phase runs.
Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (261270 => 261271)
--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2020-05-07 06:36:12 UTC (rev 261270)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2020-05-07 07:00:17 UTC (rev 261271)
@@ -2678,13 +2678,6 @@
return JSValue::encode(JSValue(executionCount));
}
-static EncodedJSValue JSC_HOST_CALL functionEnableExceptionFuzz(JSGlobalObject*, CallFrame*)
-{
- DollarVMAssertScope assertScope;
- Options::useExceptionFuzz() = true;
- return JSValue::encode(jsUndefined());
-}
-
class DoNothingDebugger final : public Debugger {
WTF_MAKE_NONCOPYABLE(DoNothingDebugger);
WTF_MAKE_FAST_ALLOCATED;
@@ -3095,8 +3088,6 @@
addFunction(vm, "hasBasicBlockExecuted", functionHasBasicBlockExecuted, 2);
addFunction(vm, "basicBlockExecutionCount", functionBasicBlockExecutionCount, 2);
- addFunction(vm, "enableExceptionFuzz", functionEnableExceptionFuzz, 0);
-
addFunction(vm, "enableDebuggerModeWhenIdle", functionEnableDebuggerModeWhenIdle, 0);
addFunction(vm, "disableDebuggerModeWhenIdle", functionDisableDebuggerModeWhenIdle, 0);
Modified: trunk/Tools/ChangeLog (261270 => 261271)
--- trunk/Tools/ChangeLog 2020-05-07 06:36:12 UTC (rev 261270)
+++ trunk/Tools/ChangeLog 2020-05-07 07:00:17 UTC (rev 261271)
@@ -1,3 +1,14 @@
+2020-05-07 Mark Lam <[email protected]>
+
+ Fix broken exceptionFuzz tests.
+ https://bugs.webkit.org/show_bug.cgi?id=211550
+
+ Reviewed by Yusuke Suzuki.
+
+ Pass the --useExceptionFuzz=true option from the command line for runExceptionFuzz.
+
+ * Scripts/run-jsc-stress-tests:
+
2020-05-06 Kate Cheney <[email protected]>
ResourceLoadStatistics data summary call should create a web process pool if one doesn't exist
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (261270 => 261271)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2020-05-07 06:36:12 UTC (rev 261270)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2020-05-07 07:00:17 UTC (rev 261271)
@@ -965,7 +965,7 @@
end
def runExceptionFuzz
- subCommand = escapeAll([pathToVM.to_s, "--useDollarVM=true", $benchmark.to_s])
+ subCommand = escapeAll([pathToVM.to_s, "--useDollarVM=true", "--useExceptionFuzz=true", $benchmark.to_s])
addRunCommand("exception-fuzz", ["perl", (pathToHelpers + "js-exception-fuzz").to_s, subCommand], silentOutputHandler, simpleErrorHandler)
end
