Title: [261311] branches/safari-609-branch/Source/WebKit
- Revision
- 261311
- Author
- [email protected]
- Date
- 2020-05-07 10:58:16 -0700 (Thu, 07 May 2020)
Log Message
Cherry-pick r260474. rdar://problem/62977672
PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=210813
Reviewed by Eric Carlson.
Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
because that process is not a UI Application.
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController videoControlsManagerDidChange]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (261310 => 261311)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-05-07 17:58:13 UTC (rev 261310)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-05-07 17:58:16 UTC (rev 261311)
@@ -1,5 +1,36 @@
2020-05-07 Russell Epstein <[email protected]>
+ Cherry-pick r260474. rdar://problem/62977672
+
+ PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
+ https://bugs.webkit.org/show_bug.cgi?id=210813
+
+ Reviewed by Eric Carlson.
+
+ Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
+ because that process is not a UI Application.
+
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (-[WKFullScreenViewController videoControlsManagerDidChange]):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-04-21 Jer Noble <[email protected]>
+
+ PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
+ https://bugs.webkit.org/show_bug.cgi?id=210813
+
+ Reviewed by Eric Carlson.
+
+ Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
+ because that process is not a UI Application.
+
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (-[WKFullScreenViewController videoControlsManagerDidChange]):
+
+2020-05-07 Russell Epstein <[email protected]>
+
Apply patch. rdar://problem/62977657
2020-05-07 Alex Christensen <[email protected]>
Modified: branches/safari-609-branch/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (261310 => 261311)
--- branches/safari-609-branch/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2020-05-07 17:58:13 UTC (rev 261310)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2020-05-07 17:58:16 UTC (rev 261311)
@@ -265,7 +265,7 @@
WebCore::PlaybackSessionModel* playbackSessionModel = playbackSessionInterface ? playbackSessionInterface->playbackSessionModel() : nullptr;
self.playing = playbackSessionModel ? playbackSessionModel->isPlaying() : NO;
- [_pipButton setHidden:!playbackSessionModel];
+ [_pipButton setHidden:!playbackSessionModel || !playbackSessionModel->isPictureInPictureSupported()];
}
- (void)setPrefersStatusBarHidden:(BOOL)value
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
