Title: [261324] trunk/Tools
- Revision
- 261324
- Author
- commit-qu...@webkit.org
- Date
- 2020-05-07 12:12:30 -0700 (Thu, 07 May 2020)
Log Message
Unreviewed, reverting r260959.
https://bugs.webkit.org/show_bug.cgi?id=211587
"Causes MiniBrowser to crash when closing a window" (Requested
by ddkilzer on #webkit).
Reverted changeset:
"REGRESSION (r176862, r210483): Leaks of
BrowserWindowController in MiniBrowser/mac/AppDelegate.m"
https://bugs.webkit.org/show_bug.cgi?id=211243
https://trac.webkit.org/changeset/260959
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (261323 => 261324)
--- trunk/Tools/ChangeLog 2020-05-07 18:55:50 UTC (rev 261323)
+++ trunk/Tools/ChangeLog 2020-05-07 19:12:30 UTC (rev 261324)
@@ -1,3 +1,18 @@
+2020-05-07 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, reverting r260959.
+ https://bugs.webkit.org/show_bug.cgi?id=211587
+
+ "Causes MiniBrowser to crash when closing a window" (Requested
+ by ddkilzer on #webkit).
+
+ Reverted changeset:
+
+ "REGRESSION (r176862, r210483): Leaks of
+ BrowserWindowController in MiniBrowser/mac/AppDelegate.m"
+ https://bugs.webkit.org/show_bug.cgi?id=211243
+ https://trac.webkit.org/changeset/260959
+
2020-05-07 Darin Adler <da...@apple.com>
Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (261323 => 261324)
--- trunk/Tools/MiniBrowser/mac/AppDelegate.m 2020-05-07 18:55:50 UTC (rev 261323)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m 2020-05-07 19:12:30 UTC (rev 261324)
@@ -183,7 +183,7 @@
[_browserWindowControllers addObject:controller];
- return [controller autorelease];
+ return controller;
}
- (IBAction)newWindow:(id)sender
@@ -208,7 +208,6 @@
[_browserWindowControllers addObject:controller];
[controller loadURLString:_settingsController.defaultURL];
- [controller release];
}
- (IBAction)newEditorWindow:(id)sender
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
