Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (261440 => 261441)
--- trunk/Source/_javascript_Core/ChangeLog 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-05-09 22:40:13 UTC (rev 261441)
@@ -1,3 +1,29 @@
+2020-05-09 Ross Kirsling <[email protected]>
+
+ Fix build errors and warnings for non-unified JSCOnly
+ https://bugs.webkit.org/show_bug.cgi?id=211655
+
+ Reviewed by Darin Adler and Yusuke Suzuki.
+
+ * bytecode/BytecodeDumper.cpp:
+ (JSC::isConstantRegisterIndex): Deleted.
+ Remove unused function.
+
+ * llint/LLIntEntrypoint.cpp:
+ * llint/LLIntThunks.cpp:
+ * llint/LLIntThunks.h:
+ * runtime/AggregateErrorConstructor.cpp:
+ * runtime/AggregateErrorPrototype.cpp:
+ * wasm/js/WebAssemblyFunction.cpp:
+ Fix includes.
+
+ * tools/JSDollarVM.cpp:
+ Deal with "unused constant" warnings for needsDestruction.
+
+ * wasm/WasmLLIntPlan.cpp:
+ * wasm/WasmSignature.cpp:
+ Remove unused constants.
+
2020-05-08 Darin Adler <[email protected]>
Streamline MarkupAccumulator to improve efficiency a bit
Modified: trunk/Source/_javascript_Core/bytecode/BytecodeDumper.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/bytecode/BytecodeDumper.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeDumper.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -49,11 +49,6 @@
namespace JSC {
-static ALWAYS_INLINE bool isConstantRegisterIndex(int index)
-{
- return index >= FirstConstantRegisterIndex;
-}
-
void BytecodeDumperBase::printLocationAndOp(InstructionStream::Offset location, const char* op)
{
m_currentLocation = location;
Modified: trunk/Source/_javascript_Core/llint/LLIntEntrypoint.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/llint/LLIntEntrypoint.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/llint/LLIntEntrypoint.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -35,7 +35,6 @@
#include "LowLevelInterpreter.h"
#include "MaxFrameExtentForSlowPathCall.h"
#include "StackAlignment.h"
-#include "VM.h"
namespace JSC { namespace LLInt {
Modified: trunk/Source/_javascript_Core/llint/LLIntThunks.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/llint/LLIntThunks.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/llint/LLIntThunks.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -38,7 +38,6 @@
#include "LowLevelInterpreter.h"
#include "ProtoCallFrame.h"
#include "StackAlignment.h"
-#include "VM.h"
#include "WasmCallingConvention.h"
#include "WasmContextInlines.h"
#include <wtf/NeverDestroyed.h>
Modified: trunk/Source/_javascript_Core/llint/LLIntThunks.h (261440 => 261441)
--- trunk/Source/_javascript_Core/llint/LLIntThunks.h 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/llint/LLIntThunks.h 2020-05-09 22:40:13 UTC (rev 261441)
@@ -26,11 +26,11 @@
#pragma once
#include "MacroAssemblerCodeRef.h"
+#include "VM.h"
#include <wtf/Scope.h>
namespace JSC {
-class VM;
struct ProtoCallFrame;
typedef int64_t EncodedJSValue;
Modified: trunk/Source/_javascript_Core/runtime/AggregateErrorConstructor.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/runtime/AggregateErrorConstructor.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/runtime/AggregateErrorConstructor.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -31,8 +31,9 @@
#include "ExceptionScope.h"
#include "GCAssertions.h"
#include "JSCJSValueInlines.h"
-#include "JSCellInlines.h"
+#include "JSGlobalObjectInlines.h"
#include "RuntimeType.h"
+#include "StructureInlines.h"
#include "VMInlines.h"
namespace JSC {
Modified: trunk/Source/_javascript_Core/runtime/AggregateErrorPrototype.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/runtime/AggregateErrorPrototype.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/runtime/AggregateErrorPrototype.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -28,13 +28,11 @@
#include "AggregateError.h"
#include "CallFrame.h"
-#include "Error.h"
#include "IdentifierInlines.h"
#include "JSCJSValueInlines.h"
#include "JSCell.h"
-#include "JSCellInlines.h"
#include "JSGlobalObjectInlines.h"
-#include "JSObject.h"
+#include "JSObjectInlines.h"
#include "ThrowScope.h"
#include "VMInlines.h"
#include <wtf/Locker.h>
Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -324,7 +324,6 @@
}
typedef JSNonFinalObject Base;
- static constexpr bool needsDestruction = false;
template<typename CellType, SubspaceAccess>
static CompleteSubspace* subspaceFor(VM& vm)
{
@@ -535,6 +534,10 @@
typedef JSArray Base;
static constexpr unsigned StructureFlags = Base::StructureFlags | OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | OverridesGetPropertyNames;
+IGNORE_WARNINGS_BEGIN("unused-const-variable")
+ static constexpr bool needsDestruction = false;
+IGNORE_WARNINGS_END
+
template<typename CellType, SubspaceAccess>
static CompleteSubspace* subspaceFor(VM& vm)
{
@@ -560,8 +563,6 @@
static_cast<RuntimeArray*>(cell)->RuntimeArray::~RuntimeArray();
}
- static constexpr bool needsDestruction = false;
-
static bool getOwnPropertySlot(JSObject* object, JSGlobalObject* globalObject, PropertyName propertyName, PropertySlot& slot)
{
DollarVMAssertScope assertScope;
Modified: trunk/Source/_javascript_Core/wasm/WasmLLIntPlan.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/wasm/WasmLLIntPlan.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/wasm/WasmLLIntPlan.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -40,10 +40,6 @@
namespace JSC { namespace Wasm {
-namespace WasmLLIntPlanInternal {
-static const bool verbose = false;
-}
-
LLIntPlan::LLIntPlan(Context* context, Vector<uint8_t>&& source, AsyncWork work, CompletionTask&& task)
: Base(context, WTFMove(source), work, WTFMove(task))
{
Modified: trunk/Source/_javascript_Core/wasm/WasmSignature.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/wasm/WasmSignature.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/wasm/WasmSignature.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -38,12 +38,6 @@
namespace JSC { namespace Wasm {
-namespace {
-namespace WasmSignatureInternal {
-static constexpr bool verbose = false;
-}
-}
-
SignatureInformation* SignatureInformation::theOne { nullptr };
std::once_flag SignatureInformation::signatureInformationFlag;
Modified: trunk/Source/_javascript_Core/wasm/js/WebAssemblyFunction.cpp (261440 => 261441)
--- trunk/Source/_javascript_Core/wasm/js/WebAssemblyFunction.cpp 2020-05-09 22:29:50 UTC (rev 261440)
+++ trunk/Source/_javascript_Core/wasm/js/WebAssemblyFunction.cpp 2020-05-09 22:40:13 UTC (rev 261441)
@@ -41,7 +41,6 @@
#include "LLIntThunks.h"
#include "LinkBuffer.h"
#include "ProtoCallFrameInlines.h"
-#include "VM.h"
#include "WasmCallee.h"
#include "WasmCallingConvention.h"
#include "WasmContextInlines.h"
