Title: [261458] trunk/Source/WebCore
- Revision
- 261458
- Author
- [email protected]
- Date
- 2020-05-10 14:21:14 -0700 (Sun, 10 May 2020)
Log Message
Use makeReversedRange and get rid of one-off ReverseView
https://bugs.webkit.org/show_bug.cgi?id=211675
Reviewed by Sam Weinig.
* editing/markup.cpp:
(WebCore::ReverseView): Deleted.
(WebCore::StyledMarkupAccumulator::takeResults): Use makeReversedRange.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (261457 => 261458)
--- trunk/Source/WebCore/ChangeLog 2020-05-10 19:28:11 UTC (rev 261457)
+++ trunk/Source/WebCore/ChangeLog 2020-05-10 21:21:14 UTC (rev 261458)
@@ -1,3 +1,14 @@
+2020-05-10 Darin Adler <[email protected]>
+
+ Use makeReversedRange and get rid of one-off ReverseView
+ https://bugs.webkit.org/show_bug.cgi?id=211675
+
+ Reviewed by Sam Weinig.
+
+ * editing/markup.cpp:
+ (WebCore::ReverseView): Deleted.
+ (WebCore::StyledMarkupAccumulator::takeResults): Use makeReversedRange.
+
2020-05-10 Tim Horton <[email protected]>
Clicking a tel:// link on iPad with a trackpad presents different UI than tapping on it
Modified: trunk/Source/WebCore/editing/markup.cpp (261457 => 261458)
--- trunk/Source/WebCore/editing/markup.cpp 2020-05-10 19:28:11 UTC (rev 261457)
+++ trunk/Source/WebCore/editing/markup.cpp 2020-05-10 21:21:14 UTC (rev 261458)
@@ -394,18 +394,6 @@
return MarkupAccumulator::isAllASCII();
}
-// Stopgap until C++20 adds std::ranges::reverse_view.
-template<typename Collection> struct ReverseView {
- Collection& collection;
- decltype(collection.rbegin()) begin() const { return collection.rbegin(); }
- decltype(collection.rend()) end() const { return collection.rend(); }
- decltype(collection.size()) size() const { return collection.size(); }
- ReverseView(Collection& collection)
- : collection(collection)
- {
- }
-};
-
String StyledMarkupAccumulator::takeResults()
{
CheckedUint32 length = this->length();
@@ -413,7 +401,7 @@
length += string.length();
StringBuilder result;
result.reserveCapacity(length.unsafeGet());
- for (auto& string : ReverseView { m_reversedPrecedingMarkup })
+ for (auto& string : makeReversedRange(m_reversedPrecedingMarkup))
result.append(string);
result.append(takeMarkup());
// Remove '\0' characters because they are not visibly rendered to the user.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
