Title: [261466] trunk
Revision
261466
Author
[email protected]
Date
2020-05-10 22:16:16 -0700 (Sun, 10 May 2020)

Log Message

Update user agent quirk for bankofamerica.com
https://bugs.webkit.org/show_bug.cgi?id=211700

Patch by Michael Catanzaro <[email protected]> on 2020-05-10
Reviewed by Carlos Garcia Campos.

Source/WebCore:

The Mac platform quirk isn't working anymore. The Chrome quirk works.

* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):
(WebCore::urlRequiresMacintoshPlatform):

Tools:

* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (261465 => 261466)


--- trunk/Source/WebCore/ChangeLog	2020-05-11 04:46:12 UTC (rev 261465)
+++ trunk/Source/WebCore/ChangeLog	2020-05-11 05:16:16 UTC (rev 261466)
@@ -1,3 +1,16 @@
+2020-05-10  Michael Catanzaro  <[email protected]>
+
+        Update user agent quirk for bankofamerica.com
+        https://bugs.webkit.org/show_bug.cgi?id=211700
+
+        Reviewed by Carlos Garcia Campos.
+
+        The Mac platform quirk isn't working anymore. The Chrome quirk works.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::urlRequiresChromeBrowser):
+        (WebCore::urlRequiresMacintoshPlatform):
+
 2020-05-10  Darin Adler  <[email protected]>
 
         Remove now-unneeded HAVE(CORE_VIDEO)

Modified: trunk/Source/WebCore/platform/UserAgentQuirks.cpp (261465 => 261466)


--- trunk/Source/WebCore/platform/UserAgentQuirks.cpp	2020-05-11 04:46:12 UTC (rev 261465)
+++ trunk/Source/WebCore/platform/UserAgentQuirks.cpp	2020-05-11 05:16:16 UTC (rev 261466)
@@ -75,6 +75,12 @@
     if (domain == "auth.mayohr.com")
         return true;
 
+    // Bank of America shows an unsupported browser warning with WebKitGTK's
+    // standard user agent.
+    if (baseDomain == "bankofamerica.com")
+        return true;
+
+
     return false;
 }
 
@@ -141,11 +147,6 @@
         || domain == "exchange.tu-berlin.de")
         return true;
 
-    // Bank of America shows an unsupported browser warning with WebKitGTK's
-    // standard user agent.
-    if (baseDomain == "bankofamerica.com")
-        return true;
-
     return false;
 }
 

Modified: trunk/Tools/ChangeLog (261465 => 261466)


--- trunk/Tools/ChangeLog	2020-05-11 04:46:12 UTC (rev 261465)
+++ trunk/Tools/ChangeLog	2020-05-11 05:16:16 UTC (rev 261466)
@@ -1,3 +1,13 @@
+2020-05-10  Michael Catanzaro  <[email protected]>
+
+        Update user agent quirk for bankofamerica.com
+        https://bugs.webkit.org/show_bug.cgi?id=211700
+
+        Reviewed by Carlos Garcia Campos.
+
+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+        (TestWebKitAPI::TEST):
+
 2020-05-08  Darin Adler  <[email protected]>
 
         Streamline MarkupAccumulator to improve efficiency a bit

Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (261465 => 261466)


--- trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp	2020-05-11 04:46:12 UTC (rev 261465)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp	2020-05-11 05:16:16 UTC (rev 261466)
@@ -93,6 +93,7 @@
     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.com/");
     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
     assertUserAgentForURLHasChromeBrowserQuirk("http://auth.mayohr.com/");
+    assertUserAgentForURLHasChromeBrowserQuirk("http://bankofamerica.com/");
 
     assertUserAgentForURLHasFirefoxBrowserQuirk("http://accounts.youtube.com/");
     assertUserAgentForURLHasFirefoxBrowserQuirk("http://docs.google.com/");
@@ -117,7 +118,6 @@
     assertUserAgentForURLHasMacPlatformQuirk("http://outlook.live.com/");
     assertUserAgentForURLHasMacPlatformQuirk("http://mail.ntu.edu.tw/");
     assertUserAgentForURLHasMacPlatformQuirk("http://exchange.tu-berlin.de/");
-    assertUserAgentForURLHasMacPlatformQuirk("http://bankofamerica.com/");
 }
 
 } // namespace TestWebKitAPI
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to