Title: [261496] trunk/Tools
- Revision
- 261496
- Author
- [email protected]
- Date
- 2020-05-11 15:29:55 -0700 (Mon, 11 May 2020)
Log Message
Add some logs to diagnose why WebKitLegacy.CrossPartitionFileSchemeAccess API test times out in EWS
https://bugs.webkit.org/show_bug.cgi?id=211738
Patch by Alex Christensen <[email protected]> on 2020-05-11
Reviewed by Darin Adler.
* TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
(TestWebKitAPI::TEST):
I saw an instance of failing to make a partition because the "file" already existed.
Try cleaning up anything left from last time this test timed out to prevent it from timing out again.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (261495 => 261496)
--- trunk/Tools/ChangeLog 2020-05-11 22:13:01 UTC (rev 261495)
+++ trunk/Tools/ChangeLog 2020-05-11 22:29:55 UTC (rev 261496)
@@ -3,6 +3,18 @@
Add some logs to diagnose why WebKitLegacy.CrossPartitionFileSchemeAccess API test times out in EWS
https://bugs.webkit.org/show_bug.cgi?id=211738
+ Reviewed by Darin Adler.
+
+ * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
+ (TestWebKitAPI::TEST):
+ I saw an instance of failing to make a partition because the "file" already existed.
+ Try cleaning up anything left from last time this test timed out to prevent it from timing out again.
+
+2020-05-11 Alex Christensen <[email protected]>
+
+ Add some logs to diagnose why WebKitLegacy.CrossPartitionFileSchemeAccess API test times out in EWS
+ https://bugs.webkit.org/show_bug.cgi?id=211738
+
Reviewed by Mark Lam.
* TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm (261495 => 261496)
--- trunk/Tools/TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm 2020-05-11 22:13:01 UTC (rev 261495)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm 2020-05-11 22:29:55 UTC (rev 261496)
@@ -89,6 +89,8 @@
{
NSURL *url = "" mainBundle] URLForResource:@"CrossPartitionFileSchemeAccess" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
const char *filePath = [url fileSystemRepresentation];
+ WTFLogAlways("Cleaning up from previous run...");
+ cleanUp();
WTFLogAlways("Creating partition...");
createPartition(filePath);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
