Modified: trunk/Tools/ChangeLog (261558 => 261559)
--- trunk/Tools/ChangeLog 2020-05-12 17:00:43 UTC (rev 261558)
+++ trunk/Tools/ChangeLog 2020-05-12 17:05:16 UTC (rev 261559)
@@ -1,3 +1,14 @@
+2020-05-12 Philippe Normand <[email protected]>
+
+ [FlatPak SDK] Some packages in the SDK have missing debug symbols
+ https://bugs.webkit.org/show_bug.cgi?id=211621
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ * flatpak/flatpakutils.py:
+ (WebkitFlatpak._get_packages): Unconditionally install SDK Debug symbols, even for Release
+ builds. This should help improve the crash reports on the bots.
+
2020-05-12 Carlos Alberto Lopez Perez <[email protected]>
WPT test importer fails to update references in <link> tags
Modified: trunk/Tools/flatpak/flatpakutils.py (261558 => 261559)
--- trunk/Tools/flatpak/flatpakutils.py 2020-05-12 17:00:43 UTC (rev 261558)
+++ trunk/Tools/flatpak/flatpakutils.py 2020-05-12 17:05:16 UTC (rev 261559)
@@ -893,11 +893,15 @@
return 0
def _get_packages(self):
+ # FIXME: Make arch configurable.
+ arch = "x86_64"
self.runtime = FlatpakPackage("org.webkit.Platform", self.sdk_branch,
- self.sdk_repo, "x86_64")
+ self.sdk_repo, arch)
self.sdk = FlatpakPackage("org.webkit.Sdk", self.sdk_branch,
- self.sdk_repo, "x86_64")
+ self.sdk_repo, arch)
packages = [self.runtime, self.sdk]
+ packages.append(FlatpakPackage('org.webkit.Sdk.Debug', self.sdk_branch,
+ self.sdk_repo, arch))
# FIXME: For unknown reasons, the GL extension needs to be explicitely
# installed for Flatpak 1.2.x to be able to make use of it. Seems like
@@ -907,14 +911,9 @@
)
packages.append(FlatpakPackage("org.freedesktop.Platform.GL.default", "19.08",
- self.flathub_repo, "x86_64"))
+ self.flathub_repo, arch))
packages.append(FlatpakPackage("org.freedesktop.Platform.ffmpeg-full", "19.08",
- self.flathub_repo, "x86_64"))
-
- if self.debug:
- sdk_debug = FlatpakPackage('org.webkit.Sdk.Debug', self.sdk_branch,
- self.sdk_repo, "x86_64")
- packages.append(sdk_debug)
+ self.flathub_repo, arch))
return packages
def install_all(self):
