Title: [261564] trunk/Source/_javascript_Core
- Revision
- 261564
- Author
- [email protected]
- Date
- 2020-05-12 10:40:21 -0700 (Tue, 12 May 2020)
Log Message
-Wsign-compare warnings in FTLLowerDFGToB3.cpp and DFGSpeculativeJIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=211783
Patch by Michael Catanzaro <[email protected]> on 2020-05-12
Reviewed by Darin Adler.
This fixes -Wsign-compare warnings introduced in r260331.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueBitNot):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (261563 => 261564)
--- trunk/Source/_javascript_Core/ChangeLog 2020-05-12 17:39:50 UTC (rev 261563)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-05-12 17:40:21 UTC (rev 261564)
@@ -1,3 +1,17 @@
+2020-05-12 Michael Catanzaro <[email protected]>
+
+ -Wsign-compare warnings in FTLLowerDFGToB3.cpp and DFGSpeculativeJIT.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=211783
+
+ Reviewed by Darin Adler.
+
+ This fixes -Wsign-compare warnings introduced in r260331.
+
+ * dfg/DFGSpeculativeJIT.cpp:
+ (JSC::DFG::SpeculativeJIT::compileValueBitNot):
+ * ftl/FTLLowerDFGToB3.cpp:
+ (JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot):
+
2020-05-12 Truitt Savell <[email protected]>
Unreviewed, reverting r261542.
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (261563 => 261564)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2020-05-12 17:39:50 UTC (rev 261563)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2020-05-12 17:40:21 UTC (rev 261564)
@@ -3597,7 +3597,7 @@
// The following trick relies on details of the representation of BigInt32, and will have to be updated if we move bits around.
static_assert(JSValue::BigInt32Tag == 0x12);
- static_assert(JSValue::BigInt32Mask == 0xfffe000000000012);
+ static_assert(JSValue::BigInt32Mask == static_cast<int64_t>(0xfffe000000000012));
constexpr uint64_t maskForBigInt32Bits = 0x0000ffffffff0000;
static_assert(!(JSValue::BigInt32Mask & maskForBigInt32Bits));
m_jit.move(TrustedImm64(maskForBigInt32Bits), resultGPR);
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (261563 => 261564)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2020-05-12 17:39:50 UTC (rev 261563)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2020-05-12 17:40:21 UTC (rev 261564)
@@ -3343,7 +3343,7 @@
LValue operand = lowBigInt32(m_node->child1());
// The following trick relies on details of the representation of BigInt32, and will have to be updated if we move bits around.
static_assert(JSValue::BigInt32Tag == 0x12);
- static_assert(JSValue::BigInt32Mask == 0xfffe000000000012);
+ static_assert(JSValue::BigInt32Mask == static_cast<int64_t>(0xfffe000000000012));
uint64_t maskForBigInt32Bits = 0x0000ffffffff0000;
LValue result = m_out.bitXor(operand, m_out.constInt64(maskForBigInt32Bits));
setJSValue(result);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
