Title: [104293] trunk/LayoutTests
Revision
104293
Author
[email protected]
Date
2012-01-06 07:42:57 -0800 (Fri, 06 Jan 2012)

Log Message

make canvas-lineWidth test pass even if pixel values vary a tiny bit
https://bugs.webkit.org/show_bug.cgi?id=75627

Patch by Elliot Poger <[email protected]> on 2012-01-06
Reviewed by Stephen White.

* fast/canvas/canvas-lineWidth.js:
(compareRows):

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (104292 => 104293)


--- trunk/LayoutTests/ChangeLog	2012-01-06 15:37:57 UTC (rev 104292)
+++ trunk/LayoutTests/ChangeLog	2012-01-06 15:42:57 UTC (rev 104293)
@@ -1,3 +1,13 @@
+2012-01-06  Elliot Poger  <[email protected]>
+
+        make canvas-lineWidth test pass even if pixel values vary a tiny bit
+        https://bugs.webkit.org/show_bug.cgi?id=75627
+
+        Reviewed by Stephen White.
+
+        * fast/canvas/canvas-lineWidth.js:
+        (compareRows):
+
 2012-01-06  John Knottenbelt  <[email protected]>
 
         Rebaseline mac results after r104240.

Modified: trunk/LayoutTests/fast/canvas/canvas-lineWidth.js (104292 => 104293)


--- trunk/LayoutTests/fast/canvas/canvas-lineWidth.js	2012-01-06 15:37:57 UTC (rev 104292)
+++ trunk/LayoutTests/fast/canvas/canvas-lineWidth.js	2012-01-06 15:42:57 UTC (rev 104293)
@@ -1,10 +1,11 @@
-// Compare sections of a <canvas> to assert they are identical.
-function compareRows(ctx, y0, y1, width, height) {
+// Compare sections of a <canvas> to assert they are identical, or nearly so.
+function compareRows(ctx, y0, y1, width, height, allowableDifference) {
     var data0 = ctx.getImageData(0, y0, width, height).data;
     var data1 = ctx.getImageData(0, y1, width, height).data;
     for (var i = 0, il = data0.length; i < il; ++i) {
-        if (data0[i] != data1[i]) {
-            testFailed("Pixel at " + i + " should be " + data0[i] + " but was " + data1[i]);
+        if (Math.abs(data0[i] - data1[i]) > allowableDifference) {
+            testFailed("Pixel at " + i + " should be within " + allowableDifference +
+                " of " + data0[i] + " but was " + data1[i]);
             break;
         }
     }
@@ -40,6 +41,7 @@
     }
 }
 
-// Make sure that all rows are identical.
-compareRows(ctx, 0, 100, 600, 100);
-compareRows(ctx, 0, 200, 600, 100);
+// Make sure that all rows are nearly identical.
+// (Tiny variations are OK.)
+compareRows(ctx, 0, 100, 600, 100, 1);
+compareRows(ctx, 0, 200, 600, 100, 1);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to