Title: [261671] trunk/Source/WebKit
- Revision
- 261671
- Author
- [email protected]
- Date
- 2020-05-13 19:41:19 -0700 (Wed, 13 May 2020)
Log Message
Web Inspector: `RuntimeEnabledFeatures` should also be enabled when remotely inspecting
https://bugs.webkit.org/show_bug.cgi?id=211874
Reviewed by Timothy Hatcher.
* WebProcess/Inspector/WebInspectorUI.h:
* WebProcess/Inspector/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::enableFrontendFeatures): Added.
(WebKit::WebInspectorUI::WebInspectorUI):
* WebProcess/Inspector/RemoteWebInspectorUI.cpp:
(WebKit::RemoteWebInspectorUI::RemoteWebInspectorUI):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (261670 => 261671)
--- trunk/Source/WebKit/ChangeLog 2020-05-14 02:36:41 UTC (rev 261670)
+++ trunk/Source/WebKit/ChangeLog 2020-05-14 02:41:19 UTC (rev 261671)
@@ -1,3 +1,17 @@
+2020-05-13 Devin Rousso <[email protected]>
+
+ Web Inspector: `RuntimeEnabledFeatures` should also be enabled when remotely inspecting
+ https://bugs.webkit.org/show_bug.cgi?id=211874
+
+ Reviewed by Timothy Hatcher.
+
+ * WebProcess/Inspector/WebInspectorUI.h:
+ * WebProcess/Inspector/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::enableFrontendFeatures): Added.
+ (WebKit::WebInspectorUI::WebInspectorUI):
+ * WebProcess/Inspector/RemoteWebInspectorUI.cpp:
+ (WebKit::RemoteWebInspectorUI::RemoteWebInspectorUI):
+
2020-05-13 Megan Gardner <[email protected]>
Unreviewed Build Fix.
Modified: trunk/Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp (261670 => 261671)
--- trunk/Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp 2020-05-14 02:36:41 UTC (rev 261670)
+++ trunk/Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp 2020-05-14 02:41:19 UTC (rev 261671)
@@ -29,6 +29,7 @@
#include "RemoteWebInspectorProxyMessages.h"
#include "RemoteWebInspectorUIMessages.h"
#include "WebCoreArgumentCoders.h"
+#include "WebInspectorUI.h"
#include "WebPage.h"
#include "WebProcess.h"
#include <WebCore/CertificateInfo.h>
@@ -54,6 +55,7 @@
: m_page(page)
, m_frontendAPIDispatcher(page)
{
+ WebInspectorUI::enableFrontendFeatures();
}
void RemoteWebInspectorUI::initialize(DebuggableInfoData&& debuggableInfo, const String& backendCommandsURL)
Modified: trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp (261670 => 261671)
--- trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp 2020-05-14 02:36:41 UTC (rev 261670)
+++ trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp 2020-05-14 02:41:19 UTC (rev 261671)
@@ -48,10 +48,7 @@
return adoptRef(*new WebInspectorUI(page));
}
-WebInspectorUI::WebInspectorUI(WebPage& page)
- : m_page(page)
- , m_frontendAPIDispatcher(page)
- , m_debuggableInfo(DebuggableInfoData::empty())
+void WebInspectorUI::enableFrontendFeatures()
{
RuntimeEnabledFeatures::sharedFeatures().setInspectorAdditionsEnabled(true);
RuntimeEnabledFeatures::sharedFeatures().setImageBitmapEnabled(true);
@@ -60,6 +57,14 @@
#endif
}
+WebInspectorUI::WebInspectorUI(WebPage& page)
+ : m_page(page)
+ , m_frontendAPIDispatcher(page)
+ , m_debuggableInfo(DebuggableInfoData::empty())
+{
+ WebInspectorUI::enableFrontendFeatures();
+}
+
void WebInspectorUI::establishConnection(WebPageProxyIdentifier inspectedPageIdentifier, const DebuggableInfoData& debuggableInfo, bool underTest, unsigned inspectionLevel)
{
m_inspectedPageIdentifier = inspectedPageIdentifier;
Modified: trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.h (261670 => 261671)
--- trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.h 2020-05-14 02:36:41 UTC (rev 261670)
+++ trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.h 2020-05-14 02:41:19 UTC (rev 261671)
@@ -47,6 +47,8 @@
public:
static Ref<WebInspectorUI> create(WebPage&);
+ static void enableFrontendFeatures();
+
// Implemented in generated WebInspectorUIMessageReceiver.cpp
void didReceiveMessage(IPC::Connection&, IPC::Decoder&) override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
