Title: [261693] trunk/Source/WebCore
- Revision
- 261693
- Author
- andresg...@apple.com
- Date
- 2020-05-14 08:31:58 -0700 (Thu, 14 May 2020)
Log Message
Fix for crash in LayoutTest in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=211894
Reviewed by Chris Fleizach.
Several LayoutTests.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): Check backing object for nullity before dereferencing.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (261692 => 261693)
--- trunk/Source/WebCore/ChangeLog 2020-05-14 15:30:31 UTC (rev 261692)
+++ trunk/Source/WebCore/ChangeLog 2020-05-14 15:31:58 UTC (rev 261693)
@@ -1,5 +1,17 @@
2020-05-14 Andres Gonzalez <andresg...@apple.com>
+ Fix for crash in LayoutTest in isolated tree mode.
+ https://bugs.webkit.org/show_bug.cgi?id=211894
+
+ Reviewed by Chris Fleizach.
+
+ Several LayoutTests.
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): Check backing object for nullity before dereferencing.
+
+2020-05-14 Andres Gonzalez <andresg...@apple.com>
+
AXIsolatedObject::isOnScreen needs to be dispatched to the main thread.
https://bugs.webkit.org/show_bug.cgi?id=211893
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (261692 => 261693)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2020-05-14 15:30:31 UTC (rev 261692)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2020-05-14 15:31:58 UTC (rev 261693)
@@ -4512,7 +4512,7 @@
for (unsigned added = 0; added < available; ++index, ++added) {
WebAccessibilityObjectWrapper* wrapper = children[index];
// The attachment view should be returned, otherwise AX palindrome errors occur.
- BOOL isAttachment = [wrapper isKindOfClass:[WebAccessibilityObjectWrapper class]] && wrapper.axBackingObject->isAttachment() && [wrapper attachmentView];
+ BOOL isAttachment = [wrapper isKindOfClass:[WebAccessibilityObjectWrapper class]] && wrapper.axBackingObject && wrapper.axBackingObject->isAttachment() && [wrapper attachmentView];
[subarray addObject:isAttachment ? [wrapper attachmentView] : wrapper];
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
