Title: [261747] trunk/Source/_javascript_Core
Revision
261747
Author
[email protected]
Date
2020-05-15 09:44:30 -0700 (Fri, 15 May 2020)

Log Message

Remove debugging dataLogs in LinkBuffer::copyCompactAndLinkCode() for release builds.
https://bugs.webkit.org/show_bug.cgi?id=211961
<rdar://problem/63264848>

Reviewed by Keith Miller.

* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (261746 => 261747)


--- trunk/Source/_javascript_Core/ChangeLog	2020-05-15 16:04:19 UTC (rev 261746)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-05-15 16:44:30 UTC (rev 261747)
@@ -1,3 +1,14 @@
+2020-05-15  Mark Lam  <[email protected]>
+
+        Remove debugging dataLogs in LinkBuffer::copyCompactAndLinkCode() for release builds.
+        https://bugs.webkit.org/show_bug.cgi?id=211961
+        <rdar://problem/63264848>
+
+        Reviewed by Keith Miller.
+
+        * assembler/LinkBuffer.cpp:
+        (JSC::LinkBuffer::copyCompactAndLinkCode):
+
 2020-05-15  Paulo Matos  <[email protected]>
 
         Fix ARM NEON only assert

Modified: trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp (261746 => 261747)


--- trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp	2020-05-15 16:04:19 UTC (rev 261746)
+++ trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp	2020-05-15 16:44:30 UTC (rev 261747)
@@ -237,8 +237,10 @@
 
 #if CPU(ARM64E) && ENABLE(FAST_JIT_PERMISSIONS)
     if (verifyUncompactedHash.finalHash() != expectedFinalHash) {
+#ifndef NDEBUG
         dataLogLn("Hashes don't match: ", RawPointer(bitwise_cast<void*>(static_cast<uintptr_t>(verifyUncompactedHash.finalHash()))), " ", RawPointer(bitwise_cast<void*>(static_cast<uintptr_t>(expectedFinalHash))));
         dataLogLn("Crashing!");
+#endif
         CRASH();
     }
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to