Title: [261869] trunk/LayoutTests
Revision
261869
Author
simon.fra...@apple.com
Date
2020-05-19 10:20:00 -0700 (Tue, 19 May 2020)

Log Message

[ macOS wk2 ] fast/scrolling/rtl-point-in-iframe.html sometimes fails
https://bugs.webkit.org/show_bug.cgi?id=212062

Reviewed by Noam Rosenthal.

Convert the test to use monitorWheelEvents/callAfterScrollingCompletes() to attempt
to fix flakiness.

Skip it on Windows where monitorWheelEvents() doesn't work (webkit.org/b/208559).

* fast/scrolling/rtl-point-in-iframe.html:
* platform/win/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (261868 => 261869)


--- trunk/LayoutTests/ChangeLog	2020-05-19 16:54:05 UTC (rev 261868)
+++ trunk/LayoutTests/ChangeLog	2020-05-19 17:20:00 UTC (rev 261869)
@@ -1,3 +1,18 @@
+2020-05-19  Simon Fraser  <simon.fra...@apple.com>
+
+        [ macOS wk2 ] fast/scrolling/rtl-point-in-iframe.html sometimes fails
+        https://bugs.webkit.org/show_bug.cgi?id=212062
+
+        Reviewed by Noam Rosenthal.
+        
+        Convert the test to use monitorWheelEvents/callAfterScrollingCompletes() to attempt
+        to fix flakiness.
+        
+        Skip it on Windows where monitorWheelEvents() doesn't work (webkit.org/b/208559).
+
+        * fast/scrolling/rtl-point-in-iframe.html:
+        * platform/win/TestExpectations:
+
 2020-05-19  Truitt Savell  <tsav...@apple.com>
 
         (r261505) [ Mojave Debug ] webgl/2.0.0/conformance/textures/canvas/tex-2d-rgba-rgba-unsigned_byte.html and webgl/2.0.0/conformance/textures/canvas/tex-2d-rgb-rgb-unsigned_byte.html are flaky timeouts

Modified: trunk/LayoutTests/fast/scrolling/rtl-point-in-iframe.html (261868 => 261869)


--- trunk/LayoutTests/fast/scrolling/rtl-point-in-iframe.html	2020-05-19 16:54:05 UTC (rev 261868)
+++ trunk/LayoutTests/fast/scrolling/rtl-point-in-iframe.html	2020-05-19 17:20:00 UTC (rev 261869)
@@ -48,6 +48,8 @@
 
         var startPosX = iframeTarget.offsetLeft + 20;
         var startPosY = iframeTarget.offsetTop + 20;
+
+        eventSender.monitorWheelEvents();
         eventSender.mouseMoveTo(startPosX, startPosY);
         eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'began', 'none');
         eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'changed', 'none');
@@ -56,7 +58,7 @@
         eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'none', 'begin');
         eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'none', 'continue');
         eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, 'none', 'end');
-        setTimeout(checkForScroll, 100);
+        eventSender.callAfterScrollingCompletes(checkForScroll);
     }
     
     function startTest()

Modified: trunk/LayoutTests/platform/win/TestExpectations (261868 => 261869)


--- trunk/LayoutTests/platform/win/TestExpectations	2020-05-19 16:54:05 UTC (rev 261868)
+++ trunk/LayoutTests/platform/win/TestExpectations	2020-05-19 17:20:00 UTC (rev 261869)
@@ -278,6 +278,7 @@
 scrollbars/scroll-rtl-or-bt-layer.html [ Timeout ]
 webkit.org/b/208559 fast/scrolling/arrow-key-scroll-in-rtl-document.html [ Skip ]
 webkit.org/b/208559 fast/scrolling/programmatic-scroll-to-zero-zero.html [ Skip ]
+webkit.org/b/208559 fast/scrolling/rtl-point-in-iframe.html [ Skip ]
 
 # TODO Needs testRunner.enableAutoResizeMode()
 fast/autoresize/ [ Skip ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to