Title: [261935] trunk/Source/WebKit
- Revision
- 261935
- Author
- [email protected]
- Date
- 2020-05-20 11:37:47 -0700 (Wed, 20 May 2020)
Log Message
REGRESSION (r261892) [ Mac Debug ] 4 API tests failing related to ResourceLoadStatistics
https://bugs.webkit.org/show_bug.cgi?id=212153
<rdar://problem/63452541>
Reviewed by Sihui Liu.
Accidentally deleted necessary reset() call for a SQLite statement
when converting stored statements to SQLiteStatementAutoResetScope in
https://trac.webkit.org/changeset/261892/webkit.
This statement is used in a loop with multiple bind() calls so it must be reset.
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::checkForMissingTablesInSchema):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (261934 => 261935)
--- trunk/Source/WebKit/ChangeLog 2020-05-20 18:21:10 UTC (rev 261934)
+++ trunk/Source/WebKit/ChangeLog 2020-05-20 18:37:47 UTC (rev 261935)
@@ -1,3 +1,20 @@
+2020-05-20 Kate Cheney <[email protected]>
+
+ REGRESSION (r261892) [ Mac Debug ] 4 API tests failing related to ResourceLoadStatistics
+ https://bugs.webkit.org/show_bug.cgi?id=212153
+ <rdar://problem/63452541>
+
+ Reviewed by Sihui Liu.
+
+ Accidentally deleted necessary reset() call for a SQLite statement
+ when converting stored statements to SQLiteStatementAutoResetScope in
+ https://trac.webkit.org/changeset/261892/webkit.
+
+ This statement is used in a loop with multiple bind() calls so it must be reset.
+
+ * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+ (WebKit::ResourceLoadStatisticsDatabaseStore::checkForMissingTablesInSchema):
+
2020-05-20 Eric Carlson <[email protected]>
Update some media logging
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (261934 => 261935)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2020-05-20 18:21:10 UTC (rev 261934)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2020-05-20 18:37:47 UTC (rev 261935)
@@ -352,6 +352,7 @@
RELEASE_LOG_ERROR(Network, "%p - ResourceLoadStatisticsDatabaseStore::checkForMissingTablesInSchema schema is missing table: %s", this, table.ascii().data());
missingTables.append(String(table));
}
+ statement.reset();
}
if (missingTables.isEmpty())
return WTF::nullopt;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
