Title: [261960] trunk
- Revision
- 261960
- Author
- [email protected]
- Date
- 2020-05-20 14:33:24 -0700 (Wed, 20 May 2020)
Log Message
Deprecate WKBundlePageSetPolicyClient() Injected bundle C API
https://bugs.webkit.org/show_bug.cgi?id=212166
Reviewed by Alex Christensen.
Source/WebKit:
Deprecate WKBundlePageSetPolicyClient() Injected bundle C API. Approving navigations from
the injected bundle can lead to WebProcess terminations like in <rdar://problem/60340647>
because the WebProcess is not in a position to do sandbox checks when navigating to file
URLs.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Tools:
* TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (261959 => 261960)
--- trunk/Source/WebKit/ChangeLog 2020-05-20 21:30:01 UTC (rev 261959)
+++ trunk/Source/WebKit/ChangeLog 2020-05-20 21:33:24 UTC (rev 261960)
@@ -1,3 +1,17 @@
+2020-05-20 Chris Dumez <[email protected]>
+
+ Deprecate WKBundlePageSetPolicyClient() Injected bundle C API
+ https://bugs.webkit.org/show_bug.cgi?id=212166
+
+ Reviewed by Alex Christensen.
+
+ Deprecate WKBundlePageSetPolicyClient() Injected bundle C API. Approving navigations from
+ the injected bundle can lead to WebProcess terminations like in <rdar://problem/60340647>
+ because the WebProcess is not in a position to do sandbox checks when navigating to file
+ URLs.
+
+ * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+
2020-05-20 Simon Fraser <[email protected]>
Plumb the display's nominal refresh rate down to ScrollingTree for use in scroll synchronization
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h (261959 => 261960)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2020-05-20 21:30:01 UTC (rev 261959)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2020-05-20 21:33:24 UTC (rev 261960)
@@ -62,7 +62,7 @@
WK_EXPORT void WKBundlePageSetFormClient(WKBundlePageRef page, WKBundlePageFormClientBase* client);
WK_EXPORT void WKBundlePageSetPageLoaderClient(WKBundlePageRef page, WKBundlePageLoaderClientBase* client);
WK_EXPORT void WKBundlePageSetResourceLoadClient(WKBundlePageRef page, WKBundlePageResourceLoadClientBase* client);
-WK_EXPORT void WKBundlePageSetPolicyClient(WKBundlePageRef page, WKBundlePagePolicyClientBase* client);
+WK_EXPORT void WKBundlePageSetPolicyClient(WKBundlePageRef page, WKBundlePagePolicyClientBase* client) WK_C_API_DEPRECATED;
WK_EXPORT void WKBundlePageSetUIClient(WKBundlePageRef page, WKBundlePageUIClientBase* client);
WK_EXPORT void WKBundlePageSetFullScreenClient(WKBundlePageRef page, WKBundlePageFullScreenClientBase* client);
Modified: trunk/Tools/ChangeLog (261959 => 261960)
--- trunk/Tools/ChangeLog 2020-05-20 21:30:01 UTC (rev 261959)
+++ trunk/Tools/ChangeLog 2020-05-20 21:33:24 UTC (rev 261960)
@@ -1,3 +1,14 @@
+2020-05-20 Chris Dumez <[email protected]>
+
+ Deprecate WKBundlePageSetPolicyClient() Injected bundle C API
+ https://bugs.webkit.org/show_bug.cgi?id=212166
+
+ Reviewed by Alex Christensen.
+
+ * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
+ * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+ (WTR::InjectedBundlePage::InjectedBundlePage):
+
2020-05-20 Myles C. Maxfield <[email protected]>
[iPadOS] -webkit-text-size-adjust:percentage doesn't work in native apps
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp (261959 => 261960)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp 2020-05-20 21:30:01 UTC (rev 261959)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp 2020-05-20 21:33:24 UTC (rev 261960)
@@ -55,7 +55,9 @@
policyClient.base.version = 0;
policyClient.decidePolicyForNavigationAction = decidePolicyForNavigationAction;
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
WKBundlePageSetPolicyClient(bundlePage, &policyClient.base);
+ALLOW_DEPRECATED_DECLARATIONS_END
}
};
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (261959 => 261960)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2020-05-20 21:30:01 UTC (rev 261959)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2020-05-20 21:33:24 UTC (rev 261960)
@@ -331,7 +331,9 @@
decidePolicyForResponse,
unableToImplementPolicy
};
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
WKBundlePageSetPolicyClient(m_page, &policyClient.base);
+ALLOW_DEPRECATED_DECLARATIONS_END
WKBundlePageUIClientV2 uiClient = {
{ 2, this },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
