Title: [261994] trunk
- Revision
- 261994
- Author
- [email protected]
- Date
- 2020-05-21 07:28:06 -0700 (Thu, 21 May 2020)
Log Message
[ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=212139
<rdar://problem/63447683>
Reviewed by Antti Koivisto.
Source/WebCore:
Uninitialized row baseline value caused unexpected cell height in nested tables.
* layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
* layout/tableformatting/TableGrid.h:
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (261993 => 261994)
--- trunk/LayoutTests/ChangeLog 2020-05-21 13:58:04 UTC (rev 261993)
+++ trunk/LayoutTests/ChangeLog 2020-05-21 14:28:06 UTC (rev 261994)
@@ -1,3 +1,13 @@
+2020-05-21 Zalan Bujtas <[email protected]>
+
+ [ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=212139
+ <rdar://problem/63447683>
+
+ Reviewed by Antti Koivisto.
+
+ * platform/mac/TestExpectations:
+
2020-05-21 Zan Dobersek <[email protected]>
Unreviewed WPE gardening. Enabling a few subdirectories under fast/,
Modified: trunk/LayoutTests/platform/mac/TestExpectations (261993 => 261994)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-05-21 13:58:04 UTC (rev 261993)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-05-21 14:28:06 UTC (rev 261994)
@@ -1959,6 +1959,4 @@
webkit.org/b/211891 imported/w3c/web-platform-tests/css/css-flexbox/flexbox_direction-row-reverse.html [ ImageOnlyFailure ]
-webkit.org/b/212139 fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html [ Skip ]
-
webkit.org/b/212165 http/tests/resourceLoadStatistics/telemetry-generation-basic-functionality-database.html [ Pass Failure ]
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (261993 => 261994)
--- trunk/Source/WebCore/ChangeLog 2020-05-21 13:58:04 UTC (rev 261993)
+++ trunk/Source/WebCore/ChangeLog 2020-05-21 14:28:06 UTC (rev 261994)
@@ -1,5 +1,19 @@
2020-05-21 Zalan Bujtas <[email protected]>
+ [ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=212139
+ <rdar://problem/63447683>
+
+ Reviewed by Antti Koivisto.
+
+ Uninitialized row baseline value caused unexpected cell height in nested tables.
+
+ * layout/tableformatting/TableFormattingContext.cpp:
+ (WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
+ * layout/tableformatting/TableGrid.h:
+
+2020-05-21 Zalan Bujtas <[email protected]>
+
[LFC][TFC] Collapse in-between cell borders
https://bugs.webkit.org/show_bug.cgi?id=212183
Modified: trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp (261993 => 261994)
--- trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp 2020-05-21 13:58:04 UTC (rev 261993)
+++ trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp 2020-05-21 14:28:06 UTC (rev 261994)
@@ -149,7 +149,7 @@
}
auto& columns = grid.columns();
- Vector<InlineLayoutUnit> rowBaselines(rows.size());
+ Vector<InlineLayoutUnit> rowBaselines(rows.size(), 0);
// Now that cells are laid out, let's compute the row baselines.
for (size_t rowIndex = 0; rowIndex < rows.size(); ++rowIndex) {
for (size_t columnIndex = 0; columnIndex < columns.size(); ++columnIndex) {
Modified: trunk/Source/WebCore/layout/tableformatting/TableGrid.h (261993 => 261994)
--- trunk/Source/WebCore/layout/tableformatting/TableGrid.h 2020-05-21 13:58:04 UTC (rev 261993)
+++ trunk/Source/WebCore/layout/tableformatting/TableGrid.h 2020-05-21 14:28:06 UTC (rev 261994)
@@ -174,7 +174,7 @@
WeakPtr<const ContainerBox> m_layoutBox;
SlotPosition m_position;
CellSpan m_span;
- InlineLayoutUnit m_baselineOffset;
+ InlineLayoutUnit m_baselineOffset { 0 };
};
class Slot {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
