Title: [262061] trunk
- Revision
- 262061
- Author
- [email protected]
- Date
- 2020-05-22 09:45:36 -0700 (Fri, 22 May 2020)
Log Message
Don't put out-of-flow boxes in anonymous flex/grid items
https://bugs.webkit.org/show_bug.cgi?id=205386
Reviewed by Manuel Rego Casasnovas.
Source/WebCore:
A single anonymous flex/grid item should just contain a contiguous
sequence of text runs.
This patch is based on https://crrev.com/533825 from Chromium.
Tests: imported/w3c/web-platform-tests/css/css-flexbox/anonymous-flex-item-004.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html
* rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation):
LayoutTests:
Expect tests to pass.
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (262060 => 262061)
--- trunk/LayoutTests/ChangeLog 2020-05-22 16:42:58 UTC (rev 262060)
+++ trunk/LayoutTests/ChangeLog 2020-05-22 16:45:36 UTC (rev 262061)
@@ -1,3 +1,14 @@
+2020-05-22 Oriol Brufau <[email protected]>
+
+ Don't put out-of-flow boxes in anonymous flex/grid items
+ https://bugs.webkit.org/show_bug.cgi?id=205386
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ Expect tests to pass.
+
+ * TestExpectations:
+
2020-05-22 Myles C. Maxfield <[email protected]>
[Cocoa] fast/text/font-collection.html is failing
Modified: trunk/LayoutTests/TestExpectations (262060 => 262061)
--- trunk/LayoutTests/TestExpectations 2020-05-22 16:42:58 UTC (rev 262060)
+++ trunk/LayoutTests/TestExpectations 2020-05-22 16:45:36 UTC (rev 262061)
@@ -1059,7 +1059,6 @@
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-013.html [ Pass Failure ]
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html [ Pass Failure ]
webkit.org/b/191367 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002.html [ ImageOnlyFailure ]
-webkit.org/b/191460 imported/w3c/web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html [ Skip ]
webkit.org/b/191461 imported/w3c/web-platform-tests/css/css-grid/grid-items/percentage-size-subitems-001.html [ ImageOnlyFailure ]
webkit.org/b/191462 imported/w3c/web-platform-tests/css/css-grid/grid-items/percentage-size-replaced-subitems-001.html [ ImageOnlyFailure ]
webkit.org/b/191463 imported/w3c/web-platform-tests/css/css-grid/grid-items/explicitly-sized-grid-item-as-table.html [ ImageOnlyFailure ]
@@ -4239,7 +4238,6 @@
webkit.org/b/210093 imported/w3c/web-platform-tests/css/css-flexbox/select-element-zero-height-001.html [ ImageOnlyFailure ]
webkit.org/b/210093 imported/w3c/web-platform-tests/css/css-flexbox/select-element-zero-height-002.html [ ImageOnlyFailure ]
webkit.org/b/210102 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-auto-min-width.html [ ImageOnlyFailure ]
-webkit.org/b/210144 imported/w3c/web-platform-tests/css/css-flexbox/anonymous-flex-item-004.html [ ImageOnlyFailure ]
webkit.org/b/210144 imported/w3c/web-platform-tests/css/css-flexbox/anonymous-flex-item-005.html [ ImageOnlyFailure ]
webkit.org/b/210465 imported/w3c/web-platform-tests/css/css-flexbox/flex-wrap-002.html [ ImageOnlyFailure ]
webkit.org/b/210475 imported/w3c/web-platform-tests/css/css-flexbox/image-items-flake-001.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (262060 => 262061)
--- trunk/Source/WebCore/ChangeLog 2020-05-22 16:42:58 UTC (rev 262060)
+++ trunk/Source/WebCore/ChangeLog 2020-05-22 16:45:36 UTC (rev 262061)
@@ -1,3 +1,21 @@
+2020-05-22 Oriol Brufau <[email protected]>
+
+ Don't put out-of-flow boxes in anonymous flex/grid items
+ https://bugs.webkit.org/show_bug.cgi?id=205386
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ A single anonymous flex/grid item should just contain a contiguous
+ sequence of text runs.
+
+ This patch is based on https://crrev.com/533825 from Chromium.
+
+ Tests: imported/w3c/web-platform-tests/css/css-flexbox/anonymous-flex-item-004.html
+ imported/w3c/web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html
+
+ * rendering/updating/RenderTreeBuilderBlock.cpp:
+ (WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation):
+
2020-05-22 Tim Horton <[email protected]>
iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back
Modified: trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp (262060 => 262061)
--- trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp 2020-05-22 16:42:58 UTC (rev 262060)
+++ trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp 2020-05-22 16:45:36 UTC (rev 262061)
@@ -222,7 +222,7 @@
ASSERT(beforeChild->isAnonymousBlock());
ASSERT(beforeChild->parent() == &parent);
}
- } else if (!parent.childrenInline() && (child->isFloatingOrOutOfFlowPositioned() || child->isInline())) {
+ } else if (!parent.childrenInline() && ((child->isFloatingOrOutOfFlowPositioned() && !parent.isFlexibleBox() && !parent.isRenderGrid()) || child->isInline())) {
// If we're inserting an inline child but all of our children are blocks, then we have to make sure
// it is put into an anomyous block box. We try to use an existing anonymous box if possible, otherwise
// a new one is created and inserted into our list of children in the appropriate position.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
