Title: [262071] trunk/Source/WebKit
Revision
262071
Author
[email protected]
Date
2020-05-22 13:33:30 -0700 (Fri, 22 May 2020)

Log Message

Excessive hang time in iOS Safari under waitForDidUpdateActivityState
https://bugs.webkit.org/show_bug.cgi?id=212272
<rdar://problem/62787789>

Reviewed by Andy Estes.

* UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState):
Make the view state change timeout equivalent on iOS and macOS.

We believe that it is preferable to paint white than block the UI
process main thread for half a second. Reduce the timeout on iOS
to be the same as it has been for years on macOS.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (262070 => 262071)


--- trunk/Source/WebKit/ChangeLog	2020-05-22 20:16:20 UTC (rev 262070)
+++ trunk/Source/WebKit/ChangeLog	2020-05-22 20:33:30 UTC (rev 262071)
@@ -1,3 +1,19 @@
+2020-05-22  Tim Horton  <[email protected]>
+
+        Excessive hang time in iOS Safari under waitForDidUpdateActivityState
+        https://bugs.webkit.org/show_bug.cgi?id=212272
+        <rdar://problem/62787789>
+
+        Reviewed by Andy Estes.
+
+        * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
+        (WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState):
+        Make the view state change timeout equivalent on iOS and macOS.
+
+        We believe that it is preferable to paint white than block the UI
+        process main thread for half a second. Reduce the timeout on iOS
+        to be the same as it has been for years on macOS.
+
 2020-05-22  Alex Christensen  <[email protected]>
 
         Add SPI to unblock third party cookies from WKWebViews with ResourceLoadStatistics turned on

Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm (262070 => 262071)


--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm	2020-05-22 20:16:20 UTC (rev 262070)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm	2020-05-22 20:33:30 UTC (rev 262071)
@@ -462,12 +462,7 @@
     static Seconds activityStateUpdateTimeout = [] {
         if (id value = [[NSUserDefaults standardUserDefaults] objectForKey:@"WebKitOverrideActivityStateUpdateTimeout"])
             return Seconds([value doubleValue]);
-
-#if PLATFORM(IOS_FAMILY)
-        return Seconds::fromMilliseconds(500);
-#else
         return Seconds::fromMilliseconds(250);
-#endif
     }();
 
     auto startTime = MonotonicTime::now();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to