Title: [262292] trunk/Source/WebCore
- Revision
- 262292
- Author
- [email protected]
- Date
- 2020-05-29 06:19:15 -0700 (Fri, 29 May 2020)
Log Message
[WebXR] ActiveDOMObjects must call suspendIfNeeded() upon creation
https://bugs.webkit.org/show_bug.cgi?id=212517
Reviewed by Žan Doberšek.
We weren't calling suspendIfNeeded() upon ActiveDOMObjects creation (XRSession and XRSystem)
and that was triggering ASSERTION FAILED: m_suspendIfNeededWasCalled.
No new tests required as this was already detected by existing tests.
* Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::WebXRSession): Call suspendIfNeeded().
* Modules/webxr/WebXRSystem.cpp:
(WebCore::WebXRSystem::WebXRSystem): Call suspendIfNeeded().
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (262291 => 262292)
--- trunk/Source/WebCore/ChangeLog 2020-05-29 13:18:06 UTC (rev 262291)
+++ trunk/Source/WebCore/ChangeLog 2020-05-29 13:19:15 UTC (rev 262292)
@@ -1,5 +1,22 @@
2020-05-29 Sergio Villar Senin <[email protected]>
+ [WebXR] ActiveDOMObjects must call suspendIfNeeded() upon creation
+ https://bugs.webkit.org/show_bug.cgi?id=212517
+
+ Reviewed by Žan Doberšek.
+
+ We weren't calling suspendIfNeeded() upon ActiveDOMObjects creation (XRSession and XRSystem)
+ and that was triggering ASSERTION FAILED: m_suspendIfNeededWasCalled.
+
+ No new tests required as this was already detected by existing tests.
+
+ * Modules/webxr/WebXRSession.cpp:
+ (WebCore::WebXRSession::WebXRSession): Call suspendIfNeeded().
+ * Modules/webxr/WebXRSystem.cpp:
+ (WebCore::WebXRSystem::WebXRSystem): Call suspendIfNeeded().
+
+2020-05-29 Sergio Villar Senin <[email protected]>
+
[WebXR] WebXRSystem::unregisterSimulatedXRDeviceForTesting() ASSERTs in m_immersiveDevices.contains(device)
https://bugs.webkit.org/show_bug.cgi?id=212516
Modified: trunk/Source/WebCore/Modules/webxr/WebXRSession.cpp (262291 => 262292)
--- trunk/Source/WebCore/Modules/webxr/WebXRSession.cpp 2020-05-29 13:18:06 UTC (rev 262291)
+++ trunk/Source/WebCore/Modules/webxr/WebXRSession.cpp 2020-05-29 13:19:15 UTC (rev 262292)
@@ -54,6 +54,7 @@
// perform the necessary platform-specific steps to initialize the device's
// tracking and rendering capabilities, including showing any necessary
// instructions to the user.
+ suspendIfNeeded();
}
WebXRSession::~WebXRSession() = default;
Modified: trunk/Source/WebCore/Modules/webxr/WebXRSystem.cpp (262291 => 262292)
--- trunk/Source/WebCore/Modules/webxr/WebXRSystem.cpp 2020-05-29 13:18:06 UTC (rev 262291)
+++ trunk/Source/WebCore/Modules/webxr/WebXRSystem.cpp 2020-05-29 13:19:15 UTC (rev 262292)
@@ -63,6 +63,7 @@
: ActiveDOMObject(&scriptExecutionContext)
{
m_inlineXRDevice = makeWeakPtr(m_defaultInlineDevice);
+ suspendIfNeeded();
}
WebXRSystem::~WebXRSystem() = default;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
