Title: [262307] trunk/Source/WebInspectorUI
- Revision
- 262307
- Author
- [email protected]
- Date
- 2020-05-29 11:32:27 -0700 (Fri, 29 May 2020)
Log Message
Web Inspector: Graphics: text editors in Keyframes section don't populate when sidebar is first shown
https://bugs.webkit.org/show_bug.cgi?id=212509
Reviewed by Timothy Hatcher.
* UserInterface/Views/AnimationDetailsSidebarPanel.js:
(WI.AnimationDetailsSidebarPanel.prototype.shown): Added.
Refresh all `CodeMirror` whenever this panel is shown.
* UserInterface/Views/Sidebar.js:
(WI.Sidebar.prototype.removeSidebarPanel):
(WI.Sidebar.prototype.selectedSidebarPanel):
(WI.Sidebar.prototype.set collapsed):
* UserInterface/Views/SidebarPanel.js:
(WI.SidebarPanel.prototype.visibilityDidChange): Deleted.
Drive-by: remove unused function.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (262306 => 262307)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-05-29 18:30:37 UTC (rev 262306)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-05-29 18:32:27 UTC (rev 262307)
@@ -1,5 +1,24 @@
2020-05-29 Devin Rousso <[email protected]>
+ Web Inspector: Graphics: text editors in Keyframes section don't populate when sidebar is first shown
+ https://bugs.webkit.org/show_bug.cgi?id=212509
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/AnimationDetailsSidebarPanel.js:
+ (WI.AnimationDetailsSidebarPanel.prototype.shown): Added.
+ Refresh all `CodeMirror` whenever this panel is shown.
+
+ * UserInterface/Views/Sidebar.js:
+ (WI.Sidebar.prototype.removeSidebarPanel):
+ (WI.Sidebar.prototype.selectedSidebarPanel):
+ (WI.Sidebar.prototype.set collapsed):
+ * UserInterface/Views/SidebarPanel.js:
+ (WI.SidebarPanel.prototype.visibilityDidChange): Deleted.
+ Drive-by: remove unused function.
+
+2020-05-29 Devin Rousso <[email protected]>
+
Web Inspector: add ITML debuggable/target type
https://bugs.webkit.org/show_bug.cgi?id=203300
<rdar://problem/56545896>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js (262306 => 262307)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js 2020-05-29 18:30:37 UTC (rev 262306)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js 2020-05-29 18:32:27 UTC (rev 262307)
@@ -138,6 +138,14 @@
codeMirror.refresh();
}
+ shown()
+ {
+ super.shown();
+
+ for (let codeMirror of this._codeMirrorSectionMap.values())
+ codeMirror.refresh();
+ }
+
// Private
_refreshIdentitySection()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js (262306 => 262307)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2020-05-29 18:30:37 UTC (rev 262306)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2020-05-29 18:32:27 UTC (rev 262307)
@@ -91,10 +91,8 @@
if (!sidebarPanel)
return;
- if (sidebarPanel.visible) {
+ if (sidebarPanel.visible)
sidebarPanel.hidden();
- sidebarPanel.visibilityDidChange();
- }
sidebarPanel.selected = false;
@@ -124,7 +122,6 @@
if (this._selectedSidebarPanel) {
this._selectedSidebarPanel.hidden();
- this._selectedSidebarPanel.visibilityDidChange();
this._selectedSidebarPanel.selected = false;
this.removeSubview(this._selectedSidebarPanel);
}
@@ -137,10 +134,8 @@
if (this._selectedSidebarPanel) {
this.addSubview(this._selectedSidebarPanel);
this._selectedSidebarPanel.selected = true;
- if (!this.collapsed) {
+ if (!this.collapsed)
this._selectedSidebarPanel.shown();
- this._selectedSidebarPanel.visibilityDidChange();
- }
}
this.dispatchEventToListeners(WI.Sidebar.Event.SidebarPanelSelected);
@@ -195,8 +190,6 @@
this._selectedSidebarPanel.shown();
else
this._selectedSidebarPanel.hidden();
-
- this._selectedSidebarPanel.visibilityDidChange();
}
this.dispatchEventToListeners(WI.Sidebar.Event.CollapsedStateDidChange);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js (262306 => 262307)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js 2020-05-29 18:30:37 UTC (rev 262306)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js 2020-05-29 18:32:27 UTC (rev 262307)
@@ -109,11 +109,6 @@
// Implemented by subclasses.
}
- visibilityDidChange()
- {
- // Implemented by subclasses.
- }
-
// Protected
get scrollElement()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
