Title: [262330] trunk/Source/WebKitLegacy/mac
- Revision
- 262330
- Author
- [email protected]
- Date
- 2020-05-29 17:42:44 -0700 (Fri, 29 May 2020)
Log Message
REGRESSION (r260306): Compatibility issue leading to crash on macOS games
<https://webkit.org/b/212546>
<rdar://problem/62624078>
Reviewed by Brent Fulgham.
* WebView/WebView.mm:
(_WebSafeForwarder._target):
(_WebSafeForwarder._defaultTarget):
- Change __weak attribute to __unsafe_unretained to fix the
crash.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (262329 => 262330)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-05-30 00:03:57 UTC (rev 262329)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-05-30 00:42:44 UTC (rev 262330)
@@ -1,3 +1,17 @@
+2020-05-29 David Kilzer <[email protected]>
+
+ REGRESSION (r260306): Compatibility issue leading to crash on macOS games
+ <https://webkit.org/b/212546>
+ <rdar://problem/62624078>
+
+ Reviewed by Brent Fulgham.
+
+ * WebView/WebView.mm:
+ (_WebSafeForwarder._target):
+ (_WebSafeForwarder._defaultTarget):
+ - Change __weak attribute to __unsafe_unretained to fix the
+ crash.
+
2020-05-29 Darin Adler <[email protected]>
Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (262329 => 262330)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-05-30 00:03:57 UTC (rev 262329)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-05-30 00:42:44 UTC (rev 262330)
@@ -564,8 +564,9 @@
@interface _WebSafeForwarder : NSObject
{
- __weak id _target;
- __weak id _defaultTarget;
+ // Do not not change _target and _defaultTarget to __weak. See <rdar://problem/62624078>.
+ __unsafe_unretained id _target;
+ __unsafe_unretained id _defaultTarget;
#if PLATFORM(IOS_FAMILY)
_WebSafeAsyncForwarder *_asyncForwarder;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
