Title: [262333] trunk/LayoutTests
Revision
262333
Author
[email protected]
Date
2020-05-29 19:10:07 -0700 (Fri, 29 May 2020)

Log Message

[css-grid] Update WPT grid-items-sizing-alignment-001.html
https://bugs.webkit.org/show_bug.cgi?id=169271

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Import updated test and expectation.

* web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001-expected.html:
* web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html:

LayoutTests:

Expect the test to pass, except on iOS (bug 212493).

* TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (262332 => 262333)


--- trunk/LayoutTests/ChangeLog	2020-05-30 01:19:25 UTC (rev 262332)
+++ trunk/LayoutTests/ChangeLog	2020-05-30 02:10:07 UTC (rev 262333)
@@ -1,3 +1,15 @@
+2020-05-29  Oriol Brufau  <[email protected]>
+
+        [css-grid] Update WPT grid-items-sizing-alignment-001.html
+        https://bugs.webkit.org/show_bug.cgi?id=169271
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Expect the test to pass, except on iOS (bug 212493).
+
+        * TestExpectations:
+        * platform/ios/TestExpectations:
+
 2020-05-29  Saam Barati  <[email protected]>
 
         Skip a few more JSC tests when $memoryLimited

Modified: trunk/LayoutTests/TestExpectations (262332 => 262333)


--- trunk/LayoutTests/TestExpectations	2020-05-30 01:19:25 UTC (rev 262332)
+++ trunk/LayoutTests/TestExpectations	2020-05-30 02:10:07 UTC (rev 262333)
@@ -1055,7 +1055,6 @@
 webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap.html [ ImageOnlyFailure ]
 
 # grid layout tests
-webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ]
 webkit.org/b/191465 imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html [ ImageOnlyFailure ]
 webkit.org/b/191465 imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html [ Pass Failure ]

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (262332 => 262333)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-05-30 01:19:25 UTC (rev 262332)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-05-30 02:10:07 UTC (rev 262333)
@@ -1,3 +1,15 @@
+2020-05-29  Oriol Brufau  <[email protected]>
+
+        [css-grid] Update WPT grid-items-sizing-alignment-001.html
+        https://bugs.webkit.org/show_bug.cgi?id=169271
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Import updated test and expectation.
+
+        * web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001-expected.html:
+        * web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html:
+
 2020-05-29  Chris Dumez  <[email protected]>
 
         Update web-platform-tests/tools from upstream

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001-expected.html (262332 => 262333)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001-expected.html	2020-05-30 01:19:25 UTC (rev 262332)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001-expected.html	2020-05-30 02:10:07 UTC (rev 262333)
@@ -2,6 +2,11 @@
 <meta charset="utf-8">
 <title>CSS Reftest Reference: Grid Item Sizing</title>
 <link rel="author" title="Manuel Rego Casasnovas" href=""
+<style>
+  button {
+    margin: 0; /* Prevent WebKit from adding some margin */
+  }
+</style>
 
 <p>Test passes if it has the same output than the reference.</p>
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html (262332 => 262333)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html	2020-05-30 01:19:25 UTC (rev 262332)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html	2020-05-30 02:10:07 UTC (rev 262333)
@@ -11,6 +11,9 @@
     grid-auto-rows: 200px;
     grid-template-columns: repeat(3, 200px);
   }
+  button {
+    margin: 0; /* Prevent WebKit from adding some margin */
+  }
 </style>
 
 <p>Test passes if it has the same output than the reference.</p>

Modified: trunk/LayoutTests/platform/ios/TestExpectations (262332 => 262333)


--- trunk/LayoutTests/platform/ios/TestExpectations	2020-05-30 01:19:25 UTC (rev 262332)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-05-30 02:10:07 UTC (rev 262333)
@@ -3527,3 +3527,5 @@
 
 webkit.org/b/212226 imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-008.html [ ImageOnlyFailure ]
 webkit.org/b/212227 imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-002.html [ ImageOnlyFailure ]
+
+webkit.org/b/212493 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to