Title: [262359] trunk
- Revision
- 262359
- Author
- [email protected]
- Date
- 2020-05-31 01:36:54 -0700 (Sun, 31 May 2020)
Log Message
<area> needs to be connected in order to navigate
https://bugs.webkit.org/show_bug.cgi?id=177357
Patch by Rob Buis <[email protected]> on 2020-05-31
Reviewed by Maciej Stachowiak.
LayoutTests/imported/w3c:
Update improved test expectation.
* web-platform-tests/html/semantics/links/following-hyperlinks/activation-behavior.window-expected.txt:
Source/WebCore:
Implement second step of cannot navigate algorithm:
https://html.spec.whatwg.org/#cannot-navigate
Test: web-platform-tests/html/semantics/links/following-hyperlinks/activation-behavior.window.html
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (262358 => 262359)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-31 08:11:50 UTC (rev 262358)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-31 08:36:54 UTC (rev 262359)
@@ -1,3 +1,14 @@
+2020-05-31 Rob Buis <[email protected]>
+
+ <area> needs to be connected in order to navigate
+ https://bugs.webkit.org/show_bug.cgi?id=177357
+
+ Reviewed by Maciej Stachowiak.
+
+ Update improved test expectation.
+
+ * web-platform-tests/html/semantics/links/following-hyperlinks/activation-behavior.window-expected.txt:
+
2020-05-31 Myles C. Maxfield <[email protected]>
Rebaseline imported/w3c/web-platform-tests/encoding/single-byte-decoder.html
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/following-hyperlinks/activation-behavior.window-expected.txt (262358 => 262359)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/following-hyperlinks/activation-behavior.window-expected.txt 2020-05-31 08:11:50 UTC (rev 262358)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/following-hyperlinks/activation-behavior.window-expected.txt 2020-05-31 08:36:54 UTC (rev 262359)
@@ -1,6 +1,6 @@
PASS <a> that is not connected should be followed
PASS <a> that is from an inactive document should not be followed
-FAIL <area> that is not connected should not be followed assert_unreached: Reached unreachable code
+PASS <area> that is not connected should not be followed
PASS <area> that is from an inactive document should not be followed
Modified: trunk/Source/WebCore/ChangeLog (262358 => 262359)
--- trunk/Source/WebCore/ChangeLog 2020-05-31 08:11:50 UTC (rev 262358)
+++ trunk/Source/WebCore/ChangeLog 2020-05-31 08:36:54 UTC (rev 262359)
@@ -1,3 +1,18 @@
+2020-05-31 Rob Buis <[email protected]>
+
+ <area> needs to be connected in order to navigate
+ https://bugs.webkit.org/show_bug.cgi?id=177357
+
+ Reviewed by Maciej Stachowiak.
+
+ Implement second step of cannot navigate algorithm:
+ https://html.spec.whatwg.org/#cannot-navigate
+
+ Test: web-platform-tests/html/semantics/links/following-hyperlinks/activation-behavior.window.html
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::handleClick):
+
2020-05-30 Sam Weinig <[email protected]>
Extended Color: Additional color cleanups
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (262358 => 262359)
--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2020-05-31 08:11:50 UTC (rev 262358)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2020-05-31 08:36:54 UTC (rev 262359)
@@ -467,6 +467,9 @@
if (!frame)
return;
+ if (!hasTagName(aTag) && !isConnected())
+ return;
+
StringBuilder url;
url.append(stripLeadingAndTrailingHTMLSpaces(attributeWithoutSynchronization(hrefAttr)));
appendServerMapMousePosition(url, event);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
