Title: [262370] trunk/Source/WebKit
Revision
262370
Author
carlo...@webkit.org
Date
2020-06-01 02:21:06 -0700 (Mon, 01 Jun 2020)

Log Message

REGRESSION(r262184): fast/forms/implicit-submission.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=212520

Reviewed by Adrian Perez de Castro.

* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::activateSelectedItem): Return early if the popup has already been closed.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (262369 => 262370)


--- trunk/Source/WebKit/ChangeLog	2020-06-01 08:59:56 UTC (rev 262369)
+++ trunk/Source/WebKit/ChangeLog	2020-06-01 09:21:06 UTC (rev 262370)
@@ -1,3 +1,13 @@
+2020-06-01  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        REGRESSION(r262184): fast/forms/implicit-submission.html is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=212520
+
+        Reviewed by Adrian Perez de Castro.
+
+        * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
+        (WebKit::WebPopupMenuProxyGtk::activateSelectedItem): Return early if the popup has already been closed.
+
 2020-06-01  Rob Buis  <rb...@igalia.com>
 
         Rename ResourceResponseBase::isHTTP to isInHTTPFamily

Modified: trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp (262369 => 262370)


--- trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp	2020-06-01 08:59:56 UTC (rev 262369)
+++ trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp	2020-06-01 09:21:06 UTC (rev 262370)
@@ -102,6 +102,9 @@
 
 void WebPopupMenuProxyGtk::activateSelectedItem()
 {
+    if (!m_popup)
+        return;
+
     GtkTreeModel* model;
     GtkTreeIter iter;
     if (!gtk_tree_selection_get_selected(gtk_tree_view_get_selection(GTK_TREE_VIEW(m_treeView)), &model, &iter))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to