Title: [262376] trunk/Source/WebCore
- Revision
- 262376
- Author
- [email protected]
- Date
- 2020-06-01 06:56:52 -0700 (Mon, 01 Jun 2020)
Log Message
[Win] When GraphicsLayerCA::m_uncommittedChanges is initialized with a non-zero value, nothing is painted.
https://bugs.webkit.org/show_bug.cgi?id=168666
Reviewed by Maciej Stachowiak.
When m_uncommittedChanges is initialized with a non-zero value, client().notifyFlushRequired() will not be
called in the first call to noteLayerPropertyChanged(), see https://bugs.webkit.org/show_bug.cgi?id=64808.
Covered by existing tests.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::initialize):
* platform/graphics/ca/GraphicsLayerCA.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (262375 => 262376)
--- trunk/Source/WebCore/ChangeLog 2020-06-01 13:33:32 UTC (rev 262375)
+++ trunk/Source/WebCore/ChangeLog 2020-06-01 13:56:52 UTC (rev 262376)
@@ -1,3 +1,19 @@
+2020-06-01 Per Arne Vollan <[email protected]>
+
+ [Win] When GraphicsLayerCA::m_uncommittedChanges is initialized with a non-zero value, nothing is painted.
+ https://bugs.webkit.org/show_bug.cgi?id=168666
+
+ Reviewed by Maciej Stachowiak.
+
+ When m_uncommittedChanges is initialized with a non-zero value, client().notifyFlushRequired() will not be
+ called in the first call to noteLayerPropertyChanged(), see https://bugs.webkit.org/show_bug.cgi?id=64808.
+
+ Covered by existing tests.
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::initialize):
+ * platform/graphics/ca/GraphicsLayerCA.h:
+
2020-06-01 Carlos Garcia Campos <[email protected]>
[GTK4] Add printing support
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (262375 => 262376)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2020-06-01 13:33:32 UTC (rev 262375)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2020-06-01 13:56:52 UTC (rev 262376)
@@ -431,6 +431,7 @@
}
m_layer = createPlatformCALayer(platformLayerType, this);
noteLayerPropertyChanged(ContentsScaleChanged);
+ noteLayerPropertyChanged(CoverageRectChanged);
}
GraphicsLayerCA::~GraphicsLayerCA()
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h (262375 => 262376)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2020-06-01 13:33:32 UTC (rev 262375)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2020-06-01 13:56:52 UTC (rev 262376)
@@ -573,12 +573,7 @@
};
void addProcessingActionForAnimation(const String&, AnimationProcessingAction);
-#if PLATFORM(WIN)
- // FIXME: when initializing m_uncommittedChanges to a non-zero value, nothing is painted on Windows, see https://bugs.webkit.org/show_bug.cgi?id=168666.
LayerChangeFlags m_uncommittedChanges { 0 };
-#else
- LayerChangeFlags m_uncommittedChanges { CoverageRectChanged };
-#endif
RefPtr<PlatformCALayer> m_layer; // The main layer
RefPtr<PlatformCALayer> m_structuralLayer; // A layer used for structural reasons, like preserves-3d or replica-flattening. Is the parent of m_layer.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
