Title: [104378] trunk/Source/WebCore
Revision
104378
Author
[email protected]
Date
2012-01-06 22:57:47 -0800 (Fri, 06 Jan 2012)

Log Message

REGRESSION (r83075): Save as PDF does not generate any links for webkit.org and others
<http://webkit.org/b/75768> <rdar://problem/10659258>

Use RenderObject::hasOutline when determining whether to always create line boxes so that
we take in to consideration whether we'll be creating PDF link rects.

Reviewed by Dan Bernstein.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):

Modified Paths

Property Changed

Diff

Modified: trunk/Source/WebCore/ChangeLog (104377 => 104378)


--- trunk/Source/WebCore/ChangeLog	2012-01-07 06:57:32 UTC (rev 104377)
+++ trunk/Source/WebCore/ChangeLog	2012-01-07 06:57:47 UTC (rev 104378)
@@ -1,3 +1,16 @@
+2012-01-06  Mark Rowe  <[email protected]>
+
+        REGRESSION (r83075): Save as PDF does not generate any links for webkit.org and others
+        <http://webkit.org/b/75768> <rdar://problem/10659258>
+
+        Use RenderObject::hasOutline when determining whether to always create line boxes so that
+        we take in to consideration whether we'll be creating PDF link rects.
+
+        Reviewed by Dan Bernstein.
+
+        * rendering/RenderInline.cpp:
+        (WebCore::RenderInline::styleDidChange):
+
 2012-01-06  Sheriff Bot  <[email protected]>
 
         Unreviewed, rolling out r104373 and r104374.
Property changes on: trunk/Source/WebCore/ChangeLog
___________________________________________________________________

Deleted: svn:executable

Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (104377 => 104378)


--- trunk/Source/WebCore/rendering/RenderInline.cpp	2012-01-07 06:57:32 UTC (rev 104377)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp	2012-01-07 06:57:47 UTC (rev 104378)
@@ -147,7 +147,7 @@
     m_lineHeight = -1;
 
     if (!m_alwaysCreateLineBoxes) {
-        bool alwaysCreateLineBoxes = hasSelfPaintingLayer() || hasBoxDecorations() || style()->hasPadding() || style()->hasMargin() || style()->hasOutline();
+        bool alwaysCreateLineBoxes = hasSelfPaintingLayer() || hasBoxDecorations() || style()->hasPadding() || style()->hasMargin() || hasOutline();
         if (oldStyle && alwaysCreateLineBoxes) {
             dirtyLineBoxes(false);
             setNeedsLayout(true);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to