Title: [262438] trunk/LayoutTests
- Revision
- 262438
- Author
- [email protected]
- Date
- 2020-06-02 13:44:06 -0700 (Tue, 02 Jun 2020)
Log Message
[ macOS ] scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=210351
<rdar://problem/61601464>
Reviewed by Tim Horton.
Try to deflake this test. It timed out when all the wheel events were received in the UI process
before the ViewGestureController had received a response from the web process about whether the
first event had been handled. Fix by adding a rAF() wait in the middle of sending the events.
Also register the swipe callback before starting the event sending.
* scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (262437 => 262438)
--- trunk/LayoutTests/ChangeLog 2020-06-02 20:17:13 UTC (rev 262437)
+++ trunk/LayoutTests/ChangeLog 2020-06-02 20:44:06 UTC (rev 262438)
@@ -1,3 +1,19 @@
+2020-06-02 Simon Fraser <[email protected]>
+
+ [ macOS ] scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html is flaky timing out
+ https://bugs.webkit.org/show_bug.cgi?id=210351
+ <rdar://problem/61601464>
+
+ Reviewed by Tim Horton.
+
+ Try to deflake this test. It timed out when all the wheel events were received in the UI process
+ before the ViewGestureController had received a response from the web process about whether the
+ first event had been handled. Fix by adding a rAF() wait in the middle of sending the events.
+
+ Also register the swipe callback before starting the event sending.
+
+ * scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html:
+
2020-06-02 Jacob Uphoff <[email protected]>
Landing expectations for tests that were recently imported but did not have them
Modified: trunk/LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html (262437 => 262438)
--- trunk/LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html 2020-06-02 20:17:13 UTC (rev 262437)
+++ trunk/LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html 2020-06-02 20:44:06 UTC (rev 262438)
@@ -49,6 +49,7 @@
eventSender.mouseScrollByWithWheelAndMomentumPhases(1, 0, "began", "none");
eventSender.mouseScrollByWithWheelAndMomentumPhases(10, 0, "changed", "none");
eventSender.mouseScrollByWithWheelAndMomentumPhases(10, 0, "changed", "none");
+ await UIHelper.animationFrame();
eventSender.mouseScrollByWithWheelAndMomentumPhases(10, 0, "changed", "none");
eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, "ended", "none");
return UIHelper.waitForScrollCompletion();
@@ -86,7 +87,7 @@
debug('Swipe to the left');
- await Promise.all([onScrollCompletion(mouseLocationX, mouseLocationY), onSwipeCallback()]);
+ await Promise.all([onSwipeCallback(), onScrollCompletion(mouseLocationX, mouseLocationY)]);
// Should not have received any scroll events.
shouldBe('minXOffset', '0');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
