Diff
Modified: trunk/Source/WebCore/ChangeLog (104383 => 104384)
--- trunk/Source/WebCore/ChangeLog 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/ChangeLog 2012-01-07 10:08:46 UTC (rev 104384)
@@ -1,5 +1,28 @@
2012-01-07 Andreas Kling <[email protected]>
+ Unreviewed C++ bindings build fix after r104383.
+
+ Use WTF::getPtr() to grab at impl pointer since they could be either RefPtr or raw.
+
+ * bindings/scripts/CodeGeneratorCPP.pm:
+ (GenerateImplementation):
+ * bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
+ (WebDOMTestCallback::impl):
+ * bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
+ (WebDOMTestEventConstructor::impl):
+ * bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
+ (WebDOMTestInterface::impl):
+ * bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
+ (WebDOMTestMediaQueryListListener::impl):
+ * bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
+ (WebDOMTestNamedConstructor::impl):
+ * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
+ (WebDOMTestObj::impl):
+ * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
+ (WebDOMTestSerializedScriptValueInterface::impl):
+
+2012-01-07 Andreas Kling <[email protected]>
+
Simplify HTMLCollection ownership model.
<http://webkit.org/b/75437>
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm 2012-01-07 10:08:46 UTC (rev 104384)
@@ -669,7 +669,7 @@
push(@implContent, "$implClassNameWithNamespace* ${className}::impl() const\n");
push(@implContent, "{\n");
- push(@implContent, " return m_impl ? m_impl->impl.get() : 0;\n");
+ push(@implContent, " return m_impl ? WTF::getPtr(m_impl->impl) : 0;\n");
push(@implContent, "}\n\n");
# Destructor
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestCallback.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestCallback.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestCallback.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -76,7 +76,7 @@
WebCore::TestCallback* WebDOMTestCallback::impl() const
{
- return m_impl ? m_impl->impl.get() : 0;
+ return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestCallback::~WebDOMTestCallback()
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -65,7 +65,7 @@
WebCore::TestEventConstructor* WebDOMTestEventConstructor::impl() const
{
- return m_impl ? m_impl->impl.get() : 0;
+ return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestEventConstructor::~WebDOMTestEventConstructor()
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -69,7 +69,7 @@
WebCore::TestInterface* WebDOMTestInterface::impl() const
{
- return m_impl ? m_impl->impl.get() : 0;
+ return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestInterface::~WebDOMTestInterface()
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -64,7 +64,7 @@
WebCore::TestMediaQueryListListener* WebDOMTestMediaQueryListListener::impl() const
{
- return m_impl ? m_impl->impl.get() : 0;
+ return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestMediaQueryListListener::~WebDOMTestMediaQueryListListener()
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -62,7 +62,7 @@
WebCore::TestNamedConstructor* WebDOMTestNamedConstructor::impl() const
{
- return m_impl ? m_impl->impl.get() : 0;
+ return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestNamedConstructor::~WebDOMTestNamedConstructor()
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -72,7 +72,7 @@
WebCore::TestObj* WebDOMTestObj::impl() const
{
- return m_impl ? m_impl->impl.get() : 0;
+ return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestObj::~WebDOMTestObj()
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -66,7 +66,7 @@
WebCore::TestSerializedScriptValueInterface* WebDOMTestSerializedScriptValueInterface::impl() const
{
- return m_impl ? m_impl->impl.get() : 0;
+ return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface()
