Title: [262458] branches/safari-610.1.15-branch/Source/_javascript_Core
- Revision
- 262458
- Author
- [email protected]
- Date
- 2020-06-02 16:05:13 -0700 (Tue, 02 Jun 2020)
Log Message
Cherry-pick r262389. rdar://problem/63897040
x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.
https://bugs.webkit.org/show_bug.cgi?id=212603
Reviewed by Saam Barati.
The current implementation mistakenly sets the address type to that of the value
being loaded. I encountered this issue when I was trying to do a loadb from a
global address. Because of this bug, the emitted code was trying do a load using
%al (8 byte register) as the pointer to load from. With this fix, it now loads
from %rax.
* offlineasm/x86.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog (262457 => 262458)
--- branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog 2020-06-02 22:33:46 UTC (rev 262457)
+++ branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog 2020-06-02 23:05:13 UTC (rev 262458)
@@ -1,5 +1,41 @@
2020-06-02 Alan Coon <[email protected]>
+ Cherry-pick r262389. rdar://problem/63897040
+
+ x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.
+ https://bugs.webkit.org/show_bug.cgi?id=212603
+
+ Reviewed by Saam Barati.
+
+ The current implementation mistakenly sets the address type to that of the value
+ being loaded. I encountered this issue when I was trying to do a loadb from a
+ global address. Because of this bug, the emitted code was trying do a load using
+ %al (8 byte register) as the pointer to load from. With this fix, it now loads
+ from %rax.
+
+ * offlineasm/x86.rb:
+
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-06-01 Mark Lam <[email protected]>
+
+ x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.
+ https://bugs.webkit.org/show_bug.cgi?id=212603
+
+ Reviewed by Saam Barati.
+
+ The current implementation mistakenly sets the address type to that of the value
+ being loaded. I encountered this issue when I was trying to do a loadb from a
+ global address. Because of this bug, the emitted code was trying do a load using
+ %al (8 byte register) as the pointer to load from. With this fix, it now loads
+ from %rax.
+
+ * offlineasm/x86.rb:
+
+2020-06-02 Alan Coon <[email protected]>
+
Cherry-pick r262434. rdar://problem/63891520
Change Gigacage::Config to use storage in WebConfig::g_config instead of its own.
Modified: branches/safari-610.1.15-branch/Source/_javascript_Core/offlineasm/x86.rb (262457 => 262458)
--- branches/safari-610.1.15-branch/Source/_javascript_Core/offlineasm/x86.rb 2020-06-02 22:33:46 UTC (rev 262457)
+++ branches/safari-610.1.15-branch/Source/_javascript_Core/offlineasm/x86.rb 2020-06-02 23:05:13 UTC (rev 262458)
@@ -1,4 +1,4 @@
-# Copyright (C) 2012-2018 Apple Inc. All rights reserved.
+# Copyright (C) 2012-2020 Apple Inc. All rights reserved.
# Copyright (C) 2013 Digia Plc. and/or its subsidiary(-ies)
#
# Redistribution and use in source and binary forms, with or without
@@ -447,7 +447,7 @@
else
$asm.puts "lea #{dst.x86Operand(:ptr)}, #{asmLabel}"
end
- "#{offset}(#{dst.x86Operand(kind)})"
+ "#{offset}(#{dst.x86Operand(:ptr)})"
end
end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
