Title: [262494] trunk/Tools
- Revision
- 262494
- Author
- [email protected]
- Date
- 2020-06-03 10:46:51 -0700 (Wed, 03 Jun 2020)
Log Message
[WPE] lint-test-expectations doesn't work when platform is WPE
https://bugs.webkit.org/show_bug.cgi?id=212700
Reviewed by Carlos Alberto Lopez Perez.
When passing arguments '--wpe' or '--platform=wpe*',
lint-test-expectations does nothing for WPE, despite currently
there are many lint errors in WPE's TestExpectations file.
As a side-effect of this patch, now `Tools/Scripts/webkit-path
rebaseline` lists the WPE Release and Debug bots.
* Scripts/webkitpy/port/builders.py: Add WPE to the list of
exact_matches and fuzzy_matches.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (262493 => 262494)
--- trunk/Tools/ChangeLog 2020-06-03 17:32:26 UTC (rev 262493)
+++ trunk/Tools/ChangeLog 2020-06-03 17:46:51 UTC (rev 262494)
@@ -1,3 +1,21 @@
+2020-06-03 Diego Pino Garcia <[email protected]>
+
+ [WPE] lint-test-expectations doesn't work when platform is WPE
+ https://bugs.webkit.org/show_bug.cgi?id=212700
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ When passing arguments '--wpe' or '--platform=wpe*',
+ lint-test-expectations does nothing for WPE, despite currently
+ there are many lint errors in WPE's TestExpectations file.
+
+ As a side-effect of this patch, now `Tools/Scripts/webkit-path
+ rebaseline` lists the WPE Release and Debug bots.
+
+ * Scripts/webkitpy/port/builders.py: Add WPE to the list of
+ exact_matches and fuzzy_matches.
+ * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
+
2020-06-03 Jonathan Bedard <[email protected]>
Allow using web processes for service workers even though they loaded about URLs (Follow-up fix)
Modified: trunk/Tools/Scripts/webkitpy/port/builders.py (262493 => 262494)
--- trunk/Tools/Scripts/webkitpy/port/builders.py 2020-06-03 17:32:26 UTC (rev 262493)
+++ trunk/Tools/Scripts/webkitpy/port/builders.py 2020-06-03 17:46:51 UTC (rev 262494)
@@ -75,6 +75,9 @@
"GTK Linux 32-bit Release": {"port_name": "gtk-wk2", "is_debug": False},
"GTK Linux 64-bit Debug (Tests)": {"port_name": "gtk-wk2", "is_debug": True},
"GTK Linux 64-bit Release (Tests)": {"port_name": "gtk-wk2", "is_debug": False},
+ "GTK Linux 64-bit Release Wayland (Tests)": {"port_name": "gtk-wayland", "is_debug": False},
+ "WPE Linux 64-bit Debug (Tests)": {"port_name": "wpe", "is_debug": True},
+ "WPE Linux 64-bit Release (Tests)": {"port_name": "wpe", "is_debug": False},
}
@@ -84,6 +87,7 @@
r"Apple Lion": "mac-lion",
r"Windows": "win",
r"GTK": "gtk",
+ r"WPE": "wpe",
}
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py (262493 => 262494)
--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py 2020-06-03 17:32:26 UTC (rev 262493)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py 2020-06-03 17:46:51 UTC (rev 262494)
@@ -325,7 +325,7 @@
# FIXME: change this to use the test- ports.
calls = list(filter(lambda x: x[0] not in ['perl', '/usr/bin/xcrun', '/usr/bin/ulimit'], self.tool.executive.calls))
self.assertEqual(len(calls), 1)
- self.assertEqual(len(calls[0]), 22)
+ self.assertEqual(len(calls[0]), 24)
def test_rebaseline_expectations_noop(self):
self._zero_out_test_expectations()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
