Title: [262516] trunk/LayoutTests
- Revision
- 262516
- Author
- [email protected]
- Date
- 2020-06-03 14:34:30 -0700 (Wed, 03 Jun 2020)
Log Message
Refactor long press test to reflect current behaviour.
https://bugs.webkit.org/show_bug.cgi?id=212709
<rdar://problem/59572126>
Reviewed by Wenson Hsieh.
Previously, if you long pressed on editable content, the selection assistant would be triggered
in the wrong mode and you could not modify or interact with the selection. With changes and
refactors that have happened in UIKit and WebKit, the selection can be interacted with
correctly inside of an editable area. We should now allow and test for this behavior.
* fast/events/touch/ios/long-press-on-editable-expected.txt:
* fast/events/touch/ios/long-press-on-editable.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (262515 => 262516)
--- trunk/LayoutTests/ChangeLog 2020-06-03 21:08:21 UTC (rev 262515)
+++ trunk/LayoutTests/ChangeLog 2020-06-03 21:34:30 UTC (rev 262516)
@@ -1,3 +1,19 @@
+2020-06-03 Megan Gardner <[email protected]>
+
+ Refactor long press test to reflect current behaviour.
+ https://bugs.webkit.org/show_bug.cgi?id=212709
+ <rdar://problem/59572126>
+
+ Reviewed by Wenson Hsieh.
+
+ Previously, if you long pressed on editable content, the selection assistant would be triggered
+ in the wrong mode and you could not modify or interact with the selection. With changes and
+ refactors that have happened in UIKit and WebKit, the selection can be interacted with
+ correctly inside of an editable area. We should now allow and test for this behavior.
+
+ * fast/events/touch/ios/long-press-on-editable-expected.txt:
+ * fast/events/touch/ios/long-press-on-editable.html:
+
2020-06-03 Peng Liu <[email protected]>
REGRESSION: (r262456): [ Mac ] media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html is timing out.
Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-expected.txt (262515 => 262516)
--- trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-expected.txt 2020-06-03 21:08:21 UTC (rev 262515)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-expected.txt 2020-06-03 21:34:30 UTC (rev 262516)
@@ -1,2 +1,2 @@
-PASS: no selection made
+PASS: Selected: PressMe
Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable.html (262515 => 262516)
--- trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable.html 2020-06-03 21:08:21 UTC (rev 262515)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable.html 2020-06-03 21:34:30 UTC (rev 262516)
@@ -29,9 +29,9 @@
testRunner.runUIScript(getPressScript(), function(result) {
var selectionText = document.getSelection().toString();
if (selectionText == "PressMe")
- output += 'FAILED: Selected: ' + selectionText;
+ output += 'PASS: Selected: ' + selectionText;
else
- output += 'PASS: no selection made';
+ output += 'FAILED: no selection made';
output += '<br>';
document.getElementById('target').innerHTML = output;
testRunner.notifyDone();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
