Title: [262586] trunk/Source/WebKit
Revision
262586
Author
bfulg...@apple.com
Date
2020-06-04 16:56:16 -0700 (Thu, 04 Jun 2020)

Log Message

Reduce telemetry and report generation for WebContent Process sandbox
https://bugs.webkit.org/show_bug.cgi?id=212779
<rdar://problem/63769879>

Reviewed by Per Arne Vollan.

This patch cleans up a set of telemetry and reports generated during normal
WebKit operation. Now that we understand the uses of these XPC services, we
can reduce the logging traffic.

This is important to do now, since generating the telemetry and reports has
a non-zero power cost.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (262585 => 262586)


--- trunk/Source/WebKit/ChangeLog	2020-06-04 23:54:01 UTC (rev 262585)
+++ trunk/Source/WebKit/ChangeLog	2020-06-04 23:56:16 UTC (rev 262586)
@@ -1,3 +1,21 @@
+2020-06-04  Brent Fulgham  <bfulg...@apple.com>
+
+        Reduce telemetry and report generation for WebContent Process sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=212779
+        <rdar://problem/63769879>
+
+        Reviewed by Per Arne Vollan.
+
+        This patch cleans up a set of telemetry and reports generated during normal
+        WebKit operation. Now that we understand the uses of these XPC services, we
+        can reduce the logging traffic.
+
+        This is important to do now, since generating the telemetry and reports has
+        a non-zero power cost.
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+        * WebProcess/com.apple.WebProcess.sb.in:
+
 2020-06-04  Jiewen Tan  <jiewen_...@apple.com>
 
         Disable CFNetwork AppSSO interception for Mac Catalyst

Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (262585 => 262586)


--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-06-04 23:54:01 UTC (rev 262585)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-06-04 23:56:16 UTC (rev 262586)
@@ -762,6 +762,7 @@
 (allow file-read*
     (home-literal
         "/Library/Preferences/com.apple.Accessibility.plist"
+        "/Library/Preferences/com.apple.AdLib.plist"
         "/Library/Preferences/com.apple.EmojiPreferences.plist"
         "/Library/Preferences/com.apple.InputModePreferences.plist"
         "/Library/Preferences/com.apple.LaunchServices.plist"

Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (262585 => 262586)


--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-06-04 23:54:01 UTC (rev 262585)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-06-04 23:56:16 UTC (rev 262586)
@@ -162,6 +162,7 @@
         "hw.busfrequency_max"
         "hw.cpufamily" ;; <rdar://problem/58416475>
         "hw.cputype"
+        "hw.logicalcpu"
         "hw.machine"
         "hw.memsize"
         "hw.model"
@@ -646,17 +647,24 @@
 (allow mach-lookup
        (global-name "com.apple.webinspector"))
 
+;; Still actively in use
 (allow mach-lookup
+    (global-name "com.apple.coreservices.launchservicesd")
+    (global-name "com.apple.diagnosticd")
+    (global-name "com.apple.iconservices")
+    (global-name "com.apple.iconservices.store")
+    (global-name "com.apple.powerlog.plxpclogger.xpc")
+    (global-name "com.apple.tccd.system")
+    (global-name "com.apple.trustd.agent")
+)
+
+(allow mach-lookup
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
     (with report) (with telemetry)
 #endif
     (global-name "com.apple.awdd")
     (global-name "com.apple.cookied")
-    (global-name "com.apple.diagnosticd")
-    (global-name "com.apple.iconservices")
-    (global-name "com.apple.iconservices.store")
     (global-name "com.apple.mobileassetd")
-    (global-name "com.apple.powerlog.plxpclogger.xpc")
 )
 
 ;; Various services required by AppKit and other frameworks
@@ -685,8 +693,6 @@
     (with report) (with telemetry)
 #endif
     (global-name "com.apple.PowerManagement.control")
-    (global-name "com.apple.coreservices.launchservicesd")
-    (global-name "com.apple.trustd.agent")
 )
 
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
@@ -697,13 +703,6 @@
     (global-name "com.apple.lsd.mapdb")
 )
 
-(allow mach-lookup
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
-    (with telemetry)
-#endif
-    (global-name "com.apple.tccd.system")
-)
-
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 || PLATFORM(MACCATALYST)
 ;; <rdar://problem/47268166>
 (allow mach-lookup (xpc-service-name "com.apple.MTLCompilerService"))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to