Title: [262607] trunk/Source/WebKit
- Revision
- 262607
- Author
- commit-qu...@webkit.org
- Date
- 2020-06-05 01:58:43 -0700 (Fri, 05 Jun 2020)
Log Message
REGRESSION(r262184): [GTK] Two fast/forms tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=212747
Patch by Carlos Garcia Campos <cgar...@igalia.com> on 2020-06-05
Reviewed by Adrian Perez de Castro.
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::handleKeyPress): Return early if the menu has already been closed.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (262606 => 262607)
--- trunk/Source/WebKit/ChangeLog 2020-06-05 08:57:02 UTC (rev 262606)
+++ trunk/Source/WebKit/ChangeLog 2020-06-05 08:58:43 UTC (rev 262607)
@@ -1,3 +1,13 @@
+2020-06-05 Carlos Garcia Campos <cgar...@igalia.com>
+
+ REGRESSION(r262184): [GTK] Two fast/forms tests are crashing
+ https://bugs.webkit.org/show_bug.cgi?id=212747
+
+ Reviewed by Adrian Perez de Castro.
+
+ * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
+ (WebKit::WebPopupMenuProxyGtk::handleKeyPress): Return early if the menu has already been closed.
+
2020-06-05 Youenn Fablet <you...@apple.com>
Generate code to set the runtime settings for a service worker process
Modified: trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp (262606 => 262607)
--- trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2020-06-05 08:57:02 UTC (rev 262606)
+++ trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2020-06-05 08:58:43 UTC (rev 262607)
@@ -91,6 +91,9 @@
bool WebPopupMenuProxyGtk::handleKeyPress(unsigned keyval, uint32_t timestamp)
{
+ if (!m_popup)
+ return false;
+
if (keyval == GDK_KEY_Escape) {
hidePopupMenu();
return true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
