Title: [262832] trunk/Source
- Revision
- 262832
- Author
- [email protected]
- Date
- 2020-06-09 19:16:41 -0700 (Tue, 09 Jun 2020)
Log Message
Stop using the wrong LaunchServices SPI for getting an app's localized name
https://bugs.webkit.org/show_bug.cgi?id=213003
<rdar://problem/64169000>
Reviewed by Sam Weinig.
Source/WebCore/PAL:
* pal/spi/cocoa/LaunchServicesSPI.h:
Source/WebKit:
* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant _appendAppLinkOpenActionsForURL:actions:elementInfo:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (262831 => 262832)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-06-10 02:04:48 UTC (rev 262831)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-06-10 02:16:41 UTC (rev 262832)
@@ -1,3 +1,13 @@
+2020-06-09 Tim Horton <[email protected]>
+
+ Stop using the wrong LaunchServices SPI for getting an app's localized name
+ https://bugs.webkit.org/show_bug.cgi?id=213003
+ <rdar://problem/64169000>
+
+ Reviewed by Sam Weinig.
+
+ * pal/spi/cocoa/LaunchServicesSPI.h:
+
2020-06-08 Jonathan Bedard <[email protected]>
WebCore: Guard _preconnect declaration with ENABLE(SERVER_PRECONNECT)
Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h (262831 => 262832)
--- trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h 2020-06-10 02:04:48 UTC (rev 262831)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h 2020-06-10 02:16:41 UTC (rev 262832)
@@ -46,6 +46,7 @@
#if !USE(APPLE_INTERNAL_SDK)
@interface LSResourceProxy : NSObject <NSCopying, NSSecureCoding>
+@property (nonatomic, copy, readonly) NSString *localizedName;
@end
@interface LSBundleProxy : LSResourceProxy <NSSecureCoding>
@@ -53,7 +54,6 @@
#if HAVE(APP_LINKS)
@interface LSApplicationProxy : LSBundleProxy <NSSecureCoding>
-- (NSString *)localizedNameForContext:(NSString *)context;
@end
@interface LSAppLink : NSObject <NSSecureCoding>
Modified: trunk/Source/WebKit/ChangeLog (262831 => 262832)
--- trunk/Source/WebKit/ChangeLog 2020-06-10 02:04:48 UTC (rev 262831)
+++ trunk/Source/WebKit/ChangeLog 2020-06-10 02:16:41 UTC (rev 262832)
@@ -1,3 +1,14 @@
+2020-06-09 Tim Horton <[email protected]>
+
+ Stop using the wrong LaunchServices SPI for getting an app's localized name
+ https://bugs.webkit.org/show_bug.cgi?id=213003
+ <rdar://problem/64169000>
+
+ Reviewed by Sam Weinig.
+
+ * UIProcess/ios/WKActionSheetAssistant.mm:
+ (-[WKActionSheetAssistant _appendAppLinkOpenActionsForURL:actions:elementInfo:]):
+
2020-06-09 Mark Lam <[email protected]>
Disambiguate the OverridesGetPropertyNames structure flag
Modified: trunk/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm (262831 => 262832)
--- trunk/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm 2020-06-10 02:04:48 UTC (rev 262831)
+++ trunk/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm 2020-06-10 02:16:41 UTC (rev 262832)
@@ -508,7 +508,7 @@
}];
[defaultActions addObject:openInDefaultBrowserAction];
- NSString *externalApplicationName = [appLink.targetApplicationProxy localizedNameForContext:nil];
+ NSString *externalApplicationName = appLink.targetApplicationProxy.localizedName;
if (!externalApplicationName)
return YES;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
