Title: [262843] trunk/Source/WebCore
- Revision
- 262843
- Author
- [email protected]
- Date
- 2020-06-10 09:51:19 -0700 (Wed, 10 Jun 2020)
Log Message
BaseAudioSharedUnit does not need to restart its audio unit at resume time.
https://bugs.webkit.org/show_bug.cgi?id=213021
Reviewed by Eric Carlson.
Removing a case that should not happen, and was guarded by ASSERT.
Keeping ASSERT to make sure we do not break this assumption.
* platform/mediastream/mac/BaseAudioSharedUnit.cpp:
(WebCore::BaseAudioSharedUnit::resume):
(WebCore::BaseAudioSharedUnit::suspend):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (262842 => 262843)
--- trunk/Source/WebCore/ChangeLog 2020-06-10 16:20:48 UTC (rev 262842)
+++ trunk/Source/WebCore/ChangeLog 2020-06-10 16:51:19 UTC (rev 262843)
@@ -1,5 +1,19 @@
2020-06-10 Youenn Fablet <[email protected]>
+ BaseAudioSharedUnit does not need to restart its audio unit at resume time.
+ https://bugs.webkit.org/show_bug.cgi?id=213021
+
+ Reviewed by Eric Carlson.
+
+ Removing a case that should not happen, and was guarded by ASSERT.
+ Keeping ASSERT to make sure we do not break this assumption.
+
+ * platform/mediastream/mac/BaseAudioSharedUnit.cpp:
+ (WebCore::BaseAudioSharedUnit::resume):
+ (WebCore::BaseAudioSharedUnit::suspend):
+
+2020-06-10 Youenn Fablet <[email protected]>
+
REGRESSION(r262798): fast/mediastream/media-stream-track-interrupted.html is failing
https://bugs.webkit.org/show_bug.cgi?id=213011
Modified: trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp (262842 => 262843)
--- trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp 2020-06-10 16:20:48 UTC (rev 262842)
+++ trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp 2020-06-10 16:51:19 UTC (rev 262843)
@@ -177,10 +177,6 @@
}
ASSERT(!m_producingCount);
- if (m_producingCount) {
- if (auto error = startUnit())
- return error;
- }
forEachClient([](auto& client) {
client.setMuted(false);
@@ -202,6 +198,8 @@
client.setMuted(true);
});
+ ASSERT(!m_producingCount);
+
return 0;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
