Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (262847 => 262848)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-06-10 19:08:32 UTC (rev 262847)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-06-10 19:20:39 UTC (rev 262848)
@@ -1,5 +1,28 @@
2020-06-10 Devin Rousso <[email protected]>
+ Web Inspector: text inputs should not spellcheck
+ https://bugs.webkit.org/show_bug.cgi?id=213032
+ <rdar://problem/64195429>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Base/Main.js:
+ (WI._handleDeviceSettingsTabBarButtonClicked.showUserAgentInput):
+ * UserInterface/Views/BoxShadowEditor.js:
+ (WI.BoxShadowEditor):
+ * UserInterface/Views/CookiePopover.js:
+ (WI.CookiePopover.prototype.show.createInputRow):
+ * UserInterface/Views/EditableDataGridNode.js:
+ (WI.EditableDataGridNode.prototype.createCellContent):
+ * UserInterface/Views/InputPopover.js:
+ (WI.InputPopover.prototype.show):
+ * UserInterface/Views/ProbeSetDetailsSection.js:
+ (WI.ProbeSetDetailsSection.prototype._addProbeButtonClicked):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createConsoleSettingsView):
+
+2020-06-10 Devin Rousso <[email protected]>
+
Web Inspector: XHR request with same URL as main resource will hide the main resource request
https://bugs.webkit.org/show_bug.cgi?id=212850
<rdar://problem/33072149>
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (262847 => 262848)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-06-10 19:08:32 UTC (rev 262847)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-06-10 19:20:39 UTC (rev 262848)
@@ -2224,6 +2224,7 @@
return;
userAgentValueInput = userAgentValue.appendChild(document.createElement("input"));
+ userAgentValueInput.spellcheck = false;
userAgentValueInput.value = userAgentValueInput.placeholder = WI._overridenDeviceUserAgent || navigator.userAgent;
userAgentValueInput.addEventListener("click", (clickEvent) => {
clickEvent.preventDefault();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BoxShadowEditor.js (262847 => 262848)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BoxShadowEditor.js 2020-06-10 19:08:32 UTC (rev 262847)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BoxShadowEditor.js 2020-06-10 19:20:39 UTC (rev 262848)
@@ -66,7 +66,7 @@
let offsetXRow = createInputRow("offset-x", WI.UIString("Offset X", "Offset X @ Box Shadow Editor", "Input label for the x-axis of the offset of a CSS box shadow"));
this._offsetXInput = offsetXRow.inputElement;
- this._offsetXInput.type = "text"
+ this._offsetXInput.spellcheck = false;
this._offsetXInput.addEventListener("input", this._handleOffsetXInputInput.bind(this));
this._offsetXInput.addEventListener("keydown", this._handleOffsetXInputKeyDown.bind(this));
@@ -113,7 +113,7 @@
let offsetYRow = createInputRow("offset-y", WI.UIString("Offset Y", "Offset Y @ Box Shadow Editor", "Input label for the y-axis of the offset of a CSS box shadow"));
this._offsetYInput = offsetYRow.inputElement;
- this._offsetYInput.type = "text"
+ this._offsetYInput.spellcheck = false;
this._offsetYInput.addEventListener("input", this._handleOffsetYInputInput.bind(this));
this._offsetYInput.addEventListener("keydown", this._handleOffsetYInputKeyDown.bind(this));
@@ -126,7 +126,7 @@
let blurRadiusRow = createInputRow("blur-radius", WI.UIString("Blur", "Blur @ Box Shadow Editor", "Input label for the blur radius of a CSS box shadow"));
this._blurRadiusInput = blurRadiusRow.inputElement;
- this._blurRadiusInput.type = "text"
+ this._blurRadiusInput.spellcheck = false;
this._blurRadiusInput.addEventListener("input", this._handleBlurRadiusInputInput.bind(this));
this._blurRadiusInput.addEventListener("keydown", this._handleBlurRadiusInputKeyDown.bind(this));
this._blurRadiusInput.min = 0;
@@ -137,7 +137,7 @@
let spreadRadiusRow = createInputRow("spread-radius", WI.UIString("Spread", "Spread @ Box Shadow Editor", "Input label for the spread radius of a CSS box shadow"));
this._spreadRadiusInput = spreadRadiusRow.inputElement;
- this._spreadRadiusInput.type = "text"
+ this._spreadRadiusInput.spellcheck = false;
this._spreadRadiusInput.addEventListener("input", this._handleSpreadRadiusInputInput.bind(this));
this._spreadRadiusInput.addEventListener("keydown", this._handleSpreadRadiusInputKeyDown.bind(this));
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CookiePopover.js (262847 => 262848)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CookiePopover.js 2020-06-10 19:08:32 UTC (rev 262847)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CookiePopover.js 2020-06-10 19:20:39 UTC (rev 262848)
@@ -174,6 +174,7 @@
if (cookie)
inputElement.value = value;
inputElement.placeholder = value;
+ inputElement.spellcheck = false;
inputElement.addEventListener("keydown", boundHandleInputKeyDown);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EditableDataGridNode.js (262847 => 262848)
--- trunk/Source/WebInspectorUI/UserInterface/Views/EditableDataGridNode.js 2020-06-10 19:08:32 UTC (rev 262847)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EditableDataGridNode.js 2020-06-10 19:20:39 UTC (rev 262848)
@@ -46,6 +46,7 @@
return content;
let inputElement = document.createElement("input");
+ inputElement.spellcheck = false;
inputElement.value = content;
inputElement.addEventListener("keypress", this._handleKeyPress.bind(this, columnIdentifier));
inputElement.addEventListener("blur", this._handleBlur.bind(this, columnIdentifier));
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/InputPopover.js (262847 => 262848)
--- trunk/Source/WebInspectorUI/UserInterface/Views/InputPopover.js 2020-06-10 19:08:32 UTC (rev 262847)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/InputPopover.js 2020-06-10 19:20:39 UTC (rev 262848)
@@ -58,7 +58,7 @@
}
this._inputElement = document.createElement("input");
- this._inputElement.type = "text";
+ this._inputElement.spellcheck = false;
this._inputElement.addEventListener("keydown", (event) => {
if (!isEnterKey(event))
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDetailsSection.js (262847 => 262848)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDetailsSection.js 2020-06-10 19:08:32 UTC (rev 262847)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDetailsSection.js 2020-06-10 19:20:39 UTC (rev 262848)
@@ -129,7 +129,7 @@
let textBox = content.createChild("input");
textBox.addEventListener("keypress", createProbeFromEnteredExpression.bind(this, popover));
textBox.addEventListener("click", function (event) { event.target.select(); });
- textBox.type = "text";
+ textBox.spellcheck = false;
textBox.placeholder = WI.UIString("_expression_");
popover.content = content;
let target = WI.Rect.rectFromClientRect(event.target.element.getBoundingClientRect());
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (262847 => 262848)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2020-06-10 19:08:32 UTC (rev 262847)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2020-06-10 19:20:39 UTC (rev 262848)
@@ -316,7 +316,7 @@
let consoleSavedResultAliasEditor = consoleSettingsView.addGroupWithCustomEditor(WI.UIString("Saved Result Alias:"));
let consoleSavedResultAliasInput = consoleSavedResultAliasEditor.appendChild(document.createElement("input"));
- consoleSavedResultAliasInput.type = "text";
+ consoleSavedResultAliasInput.spellcheck = false;
consoleSavedResultAliasInput.value = WI.settings.consoleSavedResultAlias.value;
consoleSavedResultAliasInput.placeholder = WI.unlocalizedString("$");
consoleSavedResultAliasInput.addEventListener("keydown", (event) => {
